From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Clive Tovero Newsgroups: gmane.emacs.devel Subject: Re: Okay to commit purely cosmetic (indendation) fixes? Date: Mon, 10 Aug 2020 11:39:10 -0400 Message-ID: References: <94dd40a5-0195-b88b-3cc1-298d32f99ad8.ref@aol.com> <94dd40a5-0195-b88b-3cc1-298d32f99ad8@aol.com> <87y2mm7owp.fsf@gnus.org> <83wo264mwo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 10 17:40:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k59u3-00036g-O9 for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Aug 2020 17:39:59 +0200 Original-Received: from localhost ([::1]:52998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k59u2-00067d-QW for ged-emacs-devel@m.gmane-mx.org; Mon, 10 Aug 2020 11:39:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k59tR-0005NJ-Bx for emacs-devel@gnu.org; Mon, 10 Aug 2020 11:39:21 -0400 Original-Received: from sonic306-21.consmr.mail.ne1.yahoo.com ([66.163.189.83]:44500) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k59tO-0000Bs-Fa for emacs-devel@gnu.org; Mon, 10 Aug 2020 11:39:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1597073955; bh=wnanT2d39v9oV5VKa6XmBNRb5fOvUmmXUwp6g11neJs=; h=Subject:Cc:References:From:Date:In-Reply-To:From:Subject; b=Q/cD+1mBJYazIMo9OgHCLuyhQnh25SqcYwfUs8GYDGhtcAZ9wnPH/EEFXTqEFftBvfKQttumP0kI9ZZl4ksIgi2O+CiF41XRHovlHGJ2TSx3+rr9JdxhWPFNxmihsCRA9Nvr3VgstTcKbo+Z4z3jKpxJ7DvCNUUNB3ZxJjgYXBkqI6ibc7JexMnR71u7+3AhdcCquXzsu3OhmTKZnmMPPGqWnleh5WAyG4ua3pEkv496mxcnYY/VwO3P2a9Lpt9uaonfq3kezl8MFh2Mur+PrLre0UNZSUJW6zvrPgmSzM50OovtSxWY/pGtOR7SXe5ZS2n1mmiexdRUcg+Yj6kCPg== X-YMail-OSG: 7iZW6kUVM1lHlWhmSWnIfqC5nBFDAFx0S.w42m2zN5VfvqwE3aF3UbLam97rcIv Xj15ngA_6fu5SlVE47DnRJ4PWqiTOakh.UOYLaWdOmi0q8aS5o95MtQx8BcIw1DDnbvJqVKOl0UD wFcCkhwlPEUBAMHHD_ZHs9e3nCTANuDZjsRNmKK4uztdf1Vhr0PrsHEARm0QlrVlKAfs1a01uyOt HzrgSN6YA9EGkvt2k7UzURWzBTES_YBq.960HIHMGhiTiT3CVIU2ynmAziKkk87zYlva1tP.2M_u hruWr_K6Zq2l0RRWjm8XGgokVs6RI4NlMvrXVtqlPDgaGzEc7M0DNY3JKLnFEQ0YBElwTS4tGfWC ggKX94qqruVR6RW9HsXg0G7_ENHOVYyc3G5fi28hpADn0jeTAAoLM4HFF_zftbD1oeLseG8ROfQP iAS3TKAt8qr_5MBGKxNCrGQhJvMnAa0wvKC_ilsz6zR7sK.laZXQlUPxlPlaHdxsi3.ifDBphqU8 ffIKgu3.45upC50lwUYyDT8cFcpiLcdb1QC7J_d9YiGI7f7RVMmZcK9v9js0SX6STw45c78NY5Q9 hDNKUE748qc1rMffPlKADT2WFqi9JOIA_2.B6RQRZz0JcwQS7APjXxYz9TARfr09qaefAMBQ6bRO cZxQm8gTolF1ZeYbQeffRJ1taDfeqwtqUmL.aeJpIwRlgMMsnAb.Co9Uo_8rEbNP0KMgzlV08CqJ yOwVcMf.aOnmE1yoe.XgQJoykYqpW8jx8p8rER0SmJJp9fKDJDpFBvZ5ki3MJB8HNNxmif7GZ_to qyH3tWV35yeTqQmCB7hyacyre.3f3xs6NcYjnzfZQb Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Mon, 10 Aug 2020 15:39:15 +0000 Original-Received: by smtp406.mail.bf1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 461b026e11e75a14b00b0e009c9896a3; Mon, 10 Aug 2020 15:39:11 +0000 (UTC) In-Reply-To: <83wo264mwo.fsf@gnu.org> Content-Language: en-US X-Mailer: WebService/1.1.16436 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) Received-SPF: pass client-ip=66.163.189.83; envelope-from=clive.tovero@aol.com; helo=sonic306-21.consmr.mail.ne1.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/10 11:39:15 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MALFORMED_FREEMAIL=1, MISSING_HEADERS=1.021, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253592 Archived-At: >> Whitespace changes make following code changes more difficult when >> digging into the history. > > Yes. They make whole lines look like due to someone who only changed > the whitespace. Thank you, I had heard the recommendation to not make whitespace-only commits, I didn't understand why. I guess I would have to know what tools you are using and what task you are doing to completely understand--many diff tools are capable of ignoring whitespace changes and highlighting whitespace. If you are looking at raw diff or something, I guess that would be a problem. > >>> By the way, could you point us to the coding standard for Emacs that >>> would would give us guidance? >> >> Nope. Perhaps somebody else can? > > I might, but I don't think I understand what coding standards are > being sought here, and in which programming language. > My use of "coding standard" was a poor choice of words, I'm sorry for that. I meant documentation of your software development process, including issues like this, a "Commiter's Guide" e.g. Then you could tell them please RTFM, and not lead to discussions like this.