From: Lars Ingebrigtsen <larsi@gnus.org>
To: Karl Fogel <kfogel@red-bean.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Okay to commit purely cosmetic (indendation) fixes?
Date: Sun, 09 Aug 2020 22:52:53 +0200 [thread overview]
Message-ID: <87ft8va6e2.fsf@gnus.org> (raw)
In-Reply-To: <87pn7zwnmy.fsf@red-bean.com> (Karl Fogel's message of "Sun, 09 Aug 2020 15:49:25 -0500")
Karl Fogel <kfogel@red-bean.com> writes:
> Are we okay with purely cosmetic commits to fix source-level formatting issues?
[...]
> Thoughts on cosmetic fixes in general and in this specific case?
In general, doing full-scale white-space fixups should be avoided, but
in this case I think it's fine -- it's limited to one "then" clause and
makes it more readable.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-09 20:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 20:49 Okay to commit purely cosmetic (indendation) fixes? Karl Fogel
2020-08-09 20:52 ` Lars Ingebrigtsen [this message]
[not found] <94dd40a5-0195-b88b-3cc1-298d32f99ad8.ref@aol.com>
2020-08-09 22:40 ` Clive Tovero
2020-08-10 10:53 ` Lars Ingebrigtsen
2020-08-10 12:23 ` Stefan Monnier
2020-08-10 16:20 ` Karl Fogel
2020-08-10 14:04 ` Eli Zaretskii
2020-08-10 15:39 ` Clive Tovero
2020-08-10 15:51 ` Eli Zaretskii
2020-08-10 17:55 ` Clive Tovero
[not found] <e0dab5e9-5603-b2cd-0eec-d708a3b44570.ref@aol.com>
2020-08-10 15:58 ` Clive Tovero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft8va6e2.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).