From: Karl Fogel <kfogel@red-bean.com>
To: Emacs developers <emacs-devel@gnu.org>
Subject: Okay to commit purely cosmetic (indendation) fixes?
Date: Sun, 09 Aug 2020 15:49:25 -0500 [thread overview]
Message-ID: <87pn7zwnmy.fsf@red-bean.com> (raw)
Are we okay with purely cosmetic commits to fix source-level formatting issues?
Specifically, in lisp/gnus/gnus-start.el, in `gnus-get-unread-articles', there is a multi-line `funcall' that is improperly indented. Here's the fix I'd like to commit:
--- lisp/gnus/gnus-start.el
+++ lisp/gnus/gnus-start.el
@@ -1637,10 +1637,10 @@ gnus-get-unread-articles
type-cache))
;; Only add groups that need updating.
(if (or (and foreign-level (null (numberp foreign-level)))
- (funcall (if one-level #'= #'<=) (gnus-info-level info)
- (if (eq (cadr method-group-list) 'foreign)
- foreign-level
- alevel)))
+ (funcall (if one-level #'= #'<=) (gnus-info-level info)
+ (if (eq (cadr method-group-list) 'foreign)
+ foreign-level
+ alevel)))
(setcar (nthcdr 2 method-group-list)
(cons info (nth 2 method-group-list)))
;; The group is inactive, so we nix out the number of unread articles.
The misindentation appears to have been introduced in commit 1f5eeb7be4ac, "Honor docstring of gnus-group-get-new-news" on 4 Feb 2016. I ran across it while debugging a non-cosmetic problem related to the persistently undocumented `dont-connect' parameter, the details of which I won't go into here, but it led to the `info' variable in this function unexpectedly remaining `nil' since being first bound to `nil' in the surrounding `let*', and then `gnus-info-level' raising an error because it's being passed `nil' instead of a number... Anyway, I may or may not ever get to the bottom of that problem, since I found a workaround for my use case, but in the meantime I could at least fix the mis-indentation I found along the way.
Thoughts on cosmetic fixes in general and in this specific case?
Best regards,
-Karl
next reply other threads:[~2020-08-09 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 20:49 Karl Fogel [this message]
2020-08-09 20:52 ` Okay to commit purely cosmetic (indendation) fixes? Lars Ingebrigtsen
[not found] <94dd40a5-0195-b88b-3cc1-298d32f99ad8.ref@aol.com>
2020-08-09 22:40 ` Clive Tovero
2020-08-10 10:53 ` Lars Ingebrigtsen
2020-08-10 12:23 ` Stefan Monnier
2020-08-10 16:20 ` Karl Fogel
2020-08-10 14:04 ` Eli Zaretskii
2020-08-10 15:39 ` Clive Tovero
2020-08-10 15:51 ` Eli Zaretskii
2020-08-10 17:55 ` Clive Tovero
[not found] <e0dab5e9-5603-b2cd-0eec-d708a3b44570.ref@aol.com>
2020-08-10 15:58 ` Clive Tovero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn7zwnmy.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).