Customizing Buffer-menu-buffer-face

Customizing Buffer-menu-buffer-face

[martin rudalics]

Is there any reason why `Buffer-menu-buffer-face' is customized in the
`font-lock-highlighting-faces' group?  The current choice (i) breaks the
convention that all faces in this group are prefixed with "font-lock-"
and (ii) falsely implies that this face is used by font-lock.  Since
the face is used in the mode-line why not customize it in the mode-line
group?

Similarly, what's the purpose of customizing `show-trailing-whitespace'
and `trailing-whitespace' in the font-lock group?

Re: Customizing Buffer-menu-buffer-face

[Richard Stallman]

    Is there any reason why `Buffer-menu-buffer-face' is customized in the
    `font-lock-highlighting-faces' group?  The current choice (i) breaks the
    convention that all faces in this group are prefixed with "font-lock-"
    and (ii) falsely implies that this face is used by font-lock.

With the existing code, there is no reason.  However, that's due
to a bug.  Fixing the bug, with the patch below, it becomes
the case that M-x font-lock-mode controls whether this face
is actually used.  And then it makes sense to put this in the
group font-lock-highlighting-faces.

However, it should also be in the group Buffer-menu.


*** buff-menu.el	09 Apr 2005 19:50:08 -0400	1.80
--- buff-menu.el	14 May 2005 14:06:54 -0400	
***************
*** 77,82 ****
--- 77,83 ----
  (defface Buffer-menu-buffer-face
    '((t (:weight bold)))
    "Face used to highlight buffer name."
+   :group 'Buffer-menu
    :group 'font-lock-highlighting-faces)
  
  (defcustom Buffer-menu-buffer+size-width 26
***************
*** 754,760 ****
  					 (int-to-string (nth 3 buffer))
  					 `(buffer-name ,(nth 2 buffer)
  					   buffer ,(car buffer)
! 					   face Buffer-menu-buffer-face
  					   mouse-face highlight
  					   help-echo "mouse-2: select this buffer"))
  		"  "
--- 755,761 ----
  					 (int-to-string (nth 3 buffer))
  					 `(buffer-name ,(nth 2 buffer)
  					   buffer ,(car buffer)
! 					   font-lock-face Buffer-menu-buffer-face
  					   mouse-face highlight
  					   help-echo "mouse-2: select this buffer"))
  		"  "

Re: Customizing Buffer-menu-buffer-face

[Richard Stallman]

    Similarly, what's the purpose of customizing `show-trailing-whitespace'
    and `trailing-whitespace' in the font-lock group?

I will move them to `convenience'.  Or is there some other group
that would be better?

Re: Customizing Buffer-menu-buffer-face

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Date: Sat, 14 May 2005 20:21:20 -0400
> Cc: emacs-devel@gnu.org
> 
>     Similarly, what's the purpose of customizing `show-trailing-whitespace'
>     and `trailing-whitespace' in the font-lock group?
> 
> I will move them to `convenience'.  Or is there some other group
> that would be better?

IMHO, `convenience' is too general; I, for one, would not think about
looking for these in that group.  The following groups sound like
better candidates:

  display, faces, font-lock-highlighting-faces, 
  whitespace, whitespace-faces

Re: Customizing Buffer-menu-buffer-face

[Richard Stallman]

    IMHO, `convenience' is too general; I, for one, would not think about
    looking for these in that group.  The following groups sound like
    better candidates:

      display, faces, font-lock-highlighting-faces, 
      whitespace, whitespace-faces

The last two seem good.