From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Customizing Buffer-menu-buffer-face
Date: Sat, 14 May 2005 20:21:18 -0400 [thread overview]
Message-ID: <E1DX6sg-0006gQ-7M@fencepost.gnu.org> (raw)
In-Reply-To: <4285AB52.4040005@gmx.at> (message from martin rudalics on Sat, 14 May 2005 09:40:02 +0200)
Is there any reason why `Buffer-menu-buffer-face' is customized in the
`font-lock-highlighting-faces' group? The current choice (i) breaks the
convention that all faces in this group are prefixed with "font-lock-"
and (ii) falsely implies that this face is used by font-lock.
With the existing code, there is no reason. However, that's due
to a bug. Fixing the bug, with the patch below, it becomes
the case that M-x font-lock-mode controls whether this face
is actually used. And then it makes sense to put this in the
group font-lock-highlighting-faces.
However, it should also be in the group Buffer-menu.
*** buff-menu.el 09 Apr 2005 19:50:08 -0400 1.80
--- buff-menu.el 14 May 2005 14:06:54 -0400
***************
*** 77,82 ****
--- 77,83 ----
(defface Buffer-menu-buffer-face
'((t (:weight bold)))
"Face used to highlight buffer name."
+ :group 'Buffer-menu
:group 'font-lock-highlighting-faces)
(defcustom Buffer-menu-buffer+size-width 26
***************
*** 754,760 ****
(int-to-string (nth 3 buffer))
`(buffer-name ,(nth 2 buffer)
buffer ,(car buffer)
! face Buffer-menu-buffer-face
mouse-face highlight
help-echo "mouse-2: select this buffer"))
" "
--- 755,761 ----
(int-to-string (nth 3 buffer))
`(buffer-name ,(nth 2 buffer)
buffer ,(car buffer)
! font-lock-face Buffer-menu-buffer-face
mouse-face highlight
help-echo "mouse-2: select this buffer"))
" "
next prev parent reply other threads:[~2005-05-15 0:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-14 7:40 Customizing Buffer-menu-buffer-face martin rudalics
2005-05-15 0:21 ` Richard Stallman [this message]
2005-05-15 0:21 ` Richard Stallman
2005-05-15 3:58 ` Eli Zaretskii
2005-05-15 22:39 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1DX6sg-0006gQ-7M@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).