From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Customizing Buffer-menu-buffer-face Date: Sat, 14 May 2005 20:21:18 -0400 Message-ID: References: <4285AB52.4040005@gmx.at> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1116123368 11159 80.91.229.2 (15 May 2005 02:16:08 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 15 May 2005 02:16:08 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 15 04:16:05 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DX8fF-0000rN-Q3 for ged-emacs-devel@m.gmane.org; Sun, 15 May 2005 04:15:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DX83P-0007at-Mw for ged-emacs-devel@m.gmane.org; Sat, 14 May 2005 21:36:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DX7IY-0001W3-NB for emacs-devel@gnu.org; Sat, 14 May 2005 20:48:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DX7DB-00083l-UQ for emacs-devel@gnu.org; Sat, 14 May 2005 20:42:30 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DX74D-00044t-Tw for emacs-devel@gnu.org; Sat, 14 May 2005 20:33:14 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DX701-00053A-5W for emacs-devel@gnu.org; Sat, 14 May 2005 20:28:53 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1DX6sg-0006gQ-7M; Sat, 14 May 2005 20:21:18 -0400 Original-To: martin rudalics In-reply-to: <4285AB52.4040005@gmx.at> (message from martin rudalics on Sat, 14 May 2005 09:40:02 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37155 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37155 Is there any reason why `Buffer-menu-buffer-face' is customized in the `font-lock-highlighting-faces' group? The current choice (i) breaks the convention that all faces in this group are prefixed with "font-lock-" and (ii) falsely implies that this face is used by font-lock. With the existing code, there is no reason. However, that's due to a bug. Fixing the bug, with the patch below, it becomes the case that M-x font-lock-mode controls whether this face is actually used. And then it makes sense to put this in the group font-lock-highlighting-faces. However, it should also be in the group Buffer-menu. *** buff-menu.el 09 Apr 2005 19:50:08 -0400 1.80 --- buff-menu.el 14 May 2005 14:06:54 -0400 *************** *** 77,82 **** --- 77,83 ---- (defface Buffer-menu-buffer-face '((t (:weight bold))) "Face used to highlight buffer name." + :group 'Buffer-menu :group 'font-lock-highlighting-faces) (defcustom Buffer-menu-buffer+size-width 26 *************** *** 754,760 **** (int-to-string (nth 3 buffer)) `(buffer-name ,(nth 2 buffer) buffer ,(car buffer) ! face Buffer-menu-buffer-face mouse-face highlight help-echo "mouse-2: select this buffer")) " " --- 755,761 ---- (int-to-string (nth 3 buffer)) `(buffer-name ,(nth 2 buffer) buffer ,(car buffer) ! font-lock-face Buffer-menu-buffer-face mouse-face highlight help-echo "mouse-2: select this buffer")) " "