From: xfq <xfq.free@gmail.com>
To: Leo Liu <sdl.web@gmail.com>
Cc: emacs-devel@gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: /srv/bzr/emacs/trunk r112347: * doc/lispintro/emacs-lisp-intro.texi (defcustom, defun, simplified-beginning-of-buffer, defvar, Building Robots, Review, save-excursion): `defun' and `defcustom' are now macros rather than special forms. (Bug#13853)
Date: Mon, 22 Apr 2013 18:31:08 +0800 [thread overview]
Message-ID: <CAAF+z6G01488=Pm1BwTTrmNRTKdoUSp=akHzdCmG=9j35-LJnQ@mail.gmail.com> (raw)
In-Reply-To: <m161zf2qzq.fsf@gmail.com>
On Mon, Apr 22, 2013 at 11:17 AM, Leo Liu <sdl.web@gmail.com> wrote:
> On 2013-04-22 02:07 +0800, Glenn Morris wrote:
>> The problem I saw with these changes, and the reason I did not fix it
>> at the time it was reported.
>
> Exactly.
>
> Doc tweaks can easily turn into bikeshedding. I think a general rule
> (for all occasional committers) is to fix obvious errors and discuss
> uncertain items before jumping the gun.
Agreed. I plan to fix all bugs I submitted, and I classified them to
obvious errors (and easy to fix), to-be-discussed, and hard-to-fix bugs.
I considered this bug as an obvious error, maybe I was wrong.
> This commit is a step backwards.
Is this change appropriate:
http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00591.html
?
--
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/
next prev parent reply other threads:[~2013-04-22 10:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1UTtCq-0003Tj-Lr@vcs.savannah.gnu.org>
2013-04-21 12:39 ` /srv/bzr/emacs/trunk r112347: * doc/lispintro/emacs-lisp-intro.texi (defcustom, defun, simplified-beginning-of-buffer, defvar, Building Robots, Review, save-excursion): `defun' and `defcustom' are now macros rather than special forms. (Bug#13853) Leo Liu
2013-04-21 13:00 ` xfq
2013-04-21 14:00 ` Dmitry Gutov
2013-04-21 16:55 ` /srv/bzr/emacs/trunk r112347: *doc/lispintro/emacs-lisp-intro.texi (defcustom, defun, simplified-beginning-of-buffer, defvar, Building Robots, Review, save-excursion): `defun' and `defcustom' are now macros rather thanspecial " Drew Adams
2013-04-21 17:14 ` Dmitry Gutov
2013-04-21 17:55 ` Stephen J. Turnbull
2013-04-22 1:47 ` Dmitry Gutov
2013-04-21 18:04 ` Drew Adams
2013-04-21 18:57 ` Stephen J. Turnbull
2013-04-21 19:40 ` /srv/bzr/emacs/trunk r112347:*doc/lispintro/emacs-lisp-intro.texi (defcustom, defun, simplified-beginning-of-buffer, defvar, Building Robots, Review, save-excursion): `defun' and `defcustom' are now macros ratherthanspecial " Drew Adams
2013-04-22 1:21 ` Stephen J. Turnbull
2013-04-22 1:35 ` /srv/bzr/emacs/trunk r112347:*doc/lispintro/emacs-lisp-intro.texi(defcustom, defun, simplified-beginning-of-buffer, defvar, Building Robots, Review, save-excursion): `defun' and `defcustom' are now macrosratherthanspecial " Drew Adams
2013-04-22 2:00 ` /srv/bzr/emacs/trunk r112347: *doc/lispintro/emacs-lisp-intro.texi (defcustom, defun, simplified-beginning-of-buffer, defvar, Building Robots, Review, save-excursion): `defun' and `defcustom' are now macros rather thanspecial " Dmitry Gutov
2013-04-21 18:07 ` /srv/bzr/emacs/trunk r112347: * doc/lispintro/emacs-lisp-intro.texi (defcustom, defun, simplified-beginning-of-buffer, defvar, Building Robots, Review, save-excursion): `defun' and `defcustom' are now macros rather than special " Glenn Morris
2013-04-21 22:54 ` xfq
2013-04-22 17:02 ` Glenn Morris
2013-04-23 0:47 ` Xue Fuqiao
2013-04-23 16:42 ` Glenn Morris
2013-04-23 22:28 ` Xue Fuqiao
2013-04-22 3:17 ` Leo Liu
2013-04-22 10:31 ` xfq [this message]
2013-04-22 14:11 ` Leo Liu
2013-04-22 14:19 ` Dmitry Gutov
2013-04-22 15:37 ` Leo Liu
2013-04-22 14:47 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAF+z6G01488=Pm1BwTTrmNRTKdoUSp=akHzdCmG=9j35-LJnQ@mail.gmail.com' \
--to=xfq.free@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).