From: Philip Kaludercic <philipk@posteo.net>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: Hanno Perrey <hanno@hoowl.se>, emacs-devel@gnu.org
Subject: Re: [ELPA] New package: jami-bot and org-jami-bot
Date: Tue, 09 Jan 2024 19:39:35 +0000 [thread overview]
Message-ID: <87y1cyqoso.fsf@posteo.net> (raw)
In-Reply-To: <CADwFkmkeSCgHHonZhYiXTJ0oqZvpvk=MPe_qBa7kT=NxnsdUwA@mail.gmail.com> (Stefan Kangas's message of "Sun, 7 Jan 2024 13:01:09 -0800")
Stefan Kangas <stefankangas@gmail.com> writes:
> Hanno Perrey <hanno@hoowl.se> writes:
>
>> I would like to propose two tightly-coupled packages for inclusion into
>> ELPA: jami-bot and org-jami-bot.
>>
>> jami-bot is an extendable chat bot for the distributed, private
>> messenger Jami. It interacts with the locally-installed Jami daemon via
>> D-Bus and reacts to both plain text messages and file transfers sent to
>> local accounts.
>>
>> org-jami-bot builds upon jami-bot and extends it with Org mode capture
>> functionality for text messages and images. It allows to schedule agenda
>> items at specific dates, compose multi-measure captures and capture
>> images -- all by sending a message via the GNU Jami messenger.
>>
>> I would like to keep maintaining both packages at their current
>> repositories:
>>
>> - https://gitlab.com/hperrey/jami-bot
>> - https://gitlab.com/hperrey/org-jami-bot
>>
>> I have signed the copyright paperwork with the FSF already and changed
>> the copyright in the respective files for both packages.
>>
>> As this is the first time I am proposing a package for ELPA, any
>> guidance on the process and feedback would be highly welcome!
>
> Philip, could you please help add these packages to GNU ELPA?
>
> The copyright assignment is all taken care of.
Sure, but first Hanno could you bump the version header, so that the
ELPA build system uses a newer commit, that includes the stylistic
changes + the updated copyright line?
A few comments from my side:
- It seems like a few variable (`jami-bot-account-user-names'?) would be
nice to have as proper user options, defined with `defcustom' and a
type.
- Try to sharp-quote (#') function symbols.
- If possible, try to join file paths using functions like
`expand-file-name' with `default-directory' set, instead of using
"low-level" string-manipulation.
- There seem to be some indentation issues (jami-bot-send-message), try
running `indent-region' on the entire buffer.
- There are a few minor checkdoc issues, consider resolving them.
next prev parent reply other threads:[~2024-01-09 19:39 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 11:21 [ELPA] New package: jami-bot and org-jami-bot Hanno Perrey
2023-12-28 21:33 ` Stefan Kangas
2023-12-29 14:08 ` Hanno Perrey
2023-12-30 3:20 ` Richard Stallman
2023-12-30 10:29 ` Hanno Perrey
2024-01-01 3:34 ` Richard Stallman
2023-12-30 12:15 ` [DISCUSSION] Possible inclusion of org-capture.el into Emacs core (was: [ELPA] New package: jami-bot and org-jami-bot) Ihor Radchenko
2023-12-30 17:43 ` Stefan Kangas
2024-01-01 3:34 ` Richard Stallman
2024-01-01 3:59 ` Richard Stallman
2024-01-01 14:05 ` Ihor Radchenko
2023-12-30 12:43 ` [DISCUSSION] org-capture.el vs remember.el " Ihor Radchenko
2023-12-30 17:20 ` Stefan Kangas
2023-12-30 19:16 ` João Távora
2023-12-30 19:19 ` João Távora
2023-12-31 18:05 ` Adam Porter
2024-01-07 21:01 ` [ELPA] New package: jami-bot and org-jami-bot Stefan Kangas
2024-01-08 21:08 ` Richard Stallman
2024-01-08 21:29 ` Ihor Radchenko
2024-01-09 3:30 ` Eli Zaretskii
2024-01-09 4:42 ` Stefan Kangas
2024-01-10 4:24 ` Richard Stallman
2024-01-10 5:36 ` Stefan Kangas
2024-01-10 4:24 ` Richard Stallman
2024-01-11 15:30 ` ELPA packages and Org mode integration (was: [ELPA] New package: jami-bot and org-jami-bot) Ihor Radchenko
2024-01-09 19:39 ` Philip Kaludercic [this message]
2024-01-11 18:51 ` [ELPA] New package: jami-bot and org-jami-bot Richard Stallman
2024-01-11 20:12 ` Stefan Kangas
2024-01-12 7:24 ` Eli Zaretskii
2024-01-12 12:38 ` Ihor Radchenko
2024-01-12 13:59 ` Eli Zaretskii
2024-01-12 14:13 ` Ihor Radchenko
2024-01-12 14:37 ` Eli Zaretskii
2024-01-12 14:45 ` Ihor Radchenko
2024-01-12 15:04 ` Eli Zaretskii
2024-01-12 15:17 ` Ihor Radchenko
2024-01-14 3:03 ` Richard Stallman
2024-01-14 3:03 ` Richard Stallman
2024-01-14 9:58 ` Stefan Kangas
2024-01-14 10:25 ` Emanuel Berg
2024-01-14 11:43 ` Ihor Radchenko
2024-01-14 10:47 ` Emanuel Berg
2024-01-17 3:29 ` Richard Stallman
2024-01-31 3:34 ` Richard Stallman
2024-02-03 9:28 ` Hanno Perrey
2024-01-15 3:12 ` Richard Stallman
2024-01-12 15:04 ` Hanno Perrey
2024-01-16 3:31 ` Richard Stallman
2024-01-17 8:00 ` Hanno Perrey
2024-01-12 14:58 ` Hanno Perrey
2024-01-14 18:46 ` Hanno Perrey
2024-01-15 7:06 ` Philip Kaludercic
2024-01-17 7:59 ` Hanno Perrey
2024-01-17 23:39 ` Philip Kaludercic
2024-01-20 14:46 ` Hanno Perrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1cyqoso.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=emacs-devel@gnu.org \
--cc=hanno@hoowl.se \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).