Re: [ELPA] New package: jami-bot and org-jami-bot

[Hanno Perrey <hanno@hoowl.se>]

Hej Philip,

I have now modified the code according to your suggestions and pushed
the changes. Some more detailed responses follow below:

> Sure, but first Hanno could you bump the version header, so that the
> ELPA build system uses a newer commit, that includes the stylistic
> changes + the updated copyright line?

Done!

> - It seems like a few variable (`jami-bot-account-user-names'?) would be
>   nice to have as proper user options, defined with `defcustom' and a
>   type.

Good idea! I have implemented that now and the types pass the
compilation, so I hope I did that correctly in all instances.

> - Try to sharp-quote (#') function symbols.

This could just be my limited Elisp-foo, but I could not find any
further places in the code where sharp-quotes seem to be appropriate. If
this was not meant as a general comment but aimed at a specific bit of
code, I would really appreciate a pointer!

> - If possible, try to join file paths using functions like
>   `expand-file-name' with `default-directory' set, instead of using
>   "low-level" string-manipulation.

I looked through the code and could not find an instance where that
wasn't already the case. Do you remember where you saw string
manipulation being used for path construction? My eyes could simply be
too tired to spot that...

> - There seem to be some indentation issues (jami-bot-send-message), try
>   running `indent-region' on the entire buffer.

Good catch, fixed!

> - There are a few minor checkdoc issues, consider resolving them.

Also resolved!

Thanks again for the feedback!

Best wishes,
Hanno