* Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
[not found] <E1TorcE-0005AU-EH@vcs.savannah.gnu.org>
@ 2012-12-29 20:37 ` Stefan Monnier
2012-12-30 10:22 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2012-12-29 20:37 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
> * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
> integers, if they are real numbers. (Bug#13282)
Why is that TRT? Or more specifically, why do we get floats here?
They should only happen when the number is too large to be represented
as a fixnum.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
2012-12-29 20:37 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to Stefan Monnier
@ 2012-12-30 10:22 ` Michael Albinus
2013-01-03 16:28 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Michael Albinus @ 2012-12-30 10:22 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
>> integers, if they are real numbers. (Bug#13282)
>
> Why is that TRT? Or more specifically, why do we get floats here?
> They should only happen when the number is too large to be represented
> as a fixnum.
That's exactly the reason. See <http://thread.gmane.org/gmane.emacs.tramp/8022/focus=8024>.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
2012-12-30 10:22 ` Michael Albinus
@ 2013-01-03 16:28 ` Stefan Monnier
2013-01-04 9:47 ` Michael Albinus
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2013-01-03 16:28 UTC (permalink / raw)
To: Michael Albinus; +Cc: emacs-devel
>>> * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
>>> integers, if they are real numbers. (Bug#13282)
>> Why is that TRT? Or more specifically, why do we get floats here?
>> They should only happen when the number is too large to be represented
>> as a fixnum.
> That's exactly the reason. See <http://thread.gmane.org/gmane.emacs.tramp/8022/focus=8024>.
But I don't see anything in the patch which checks that `round' returned
the right value (i.e. we now always return integers and never floats,
even if the value is too large to be represented as an integer).
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
2013-01-03 16:28 ` Stefan Monnier
@ 2013-01-04 9:47 ` Michael Albinus
0 siblings, 0 replies; 4+ messages in thread
From: Michael Albinus @ 2013-01-04 9:47 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> But I don't see anything in the patch which checks that `round' returned
> the right value (i.e. we now always return integers and never floats,
> even if the value is too large to be represented as an integer).
Hmm, yes. I've committed a modified version of the patch to emacs-24,
which should DTRT.
> Stefan
Best regards, Michael.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-04 9:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1TorcE-0005AU-EH@vcs.savannah.gnu.org>
2012-12-29 20:37 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to Stefan Monnier
2012-12-30 10:22 ` Michael Albinus
2013-01-03 16:28 ` Stefan Monnier
2013-01-04 9:47 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).