unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
Date: Fri, 04 Jan 2013 10:47:57 +0100	[thread overview]
Message-ID: <87wqvte0tu.fsf@gmx.de> (raw)
In-Reply-To: <jwvlicacjuo.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 03 Jan 2013 11:28:32 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> But I don't see anything in the patch which checks that `round' returned
> the right value (i.e. we now always return integers and never floats,
> even if the value is too large to be represented as an integer).

Hmm, yes. I've committed a modified version of the patch to emacs-24,
which should DTRT.

>         Stefan

Best regards, Michael.



      reply	other threads:[~2013-01-04  9:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1TorcE-0005AU-EH@vcs.savannah.gnu.org>
2012-12-29 20:37 ` [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to Stefan Monnier
2012-12-30 10:22   ` Michael Albinus
2013-01-03 16:28     ` Stefan Monnier
2013-01-04  9:47       ` Michael Albinus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqvte0tu.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).