From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to Date: Fri, 04 Jan 2013 10:47:57 +0100 Message-ID: <87wqvte0tu.fsf@gmx.de> References: <87y5gfyh3p.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1357292893 25597 80.91.229.3 (4 Jan 2013 09:48:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 4 Jan 2013 09:48:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 04 10:48:29 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tr3t5-0008Mi-5t for ged-emacs-devel@m.gmane.org; Fri, 04 Jan 2013 10:48:27 +0100 Original-Received: from localhost ([::1]:48503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr3sp-0003Hg-SF for ged-emacs-devel@m.gmane.org; Fri, 04 Jan 2013 04:48:11 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr3sl-0003Hb-Pl for emacs-devel@gnu.org; Fri, 04 Jan 2013 04:48:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tr3sk-0000Qp-RZ for emacs-devel@gnu.org; Fri, 04 Jan 2013 04:48:07 -0500 Original-Received: from mout.gmx.net ([212.227.17.20]:49557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tr3sk-0000QI-I5 for emacs-devel@gnu.org; Fri, 04 Jan 2013 04:48:06 -0500 Original-Received: from mailout-de.gmx.net ([10.1.76.24]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MISg5-1TrtMZ1Udj-004Amp for ; Fri, 04 Jan 2013 10:48:04 +0100 Original-Received: (qmail invoked by alias); 04 Jan 2013 09:48:03 -0000 Original-Received: from p57BB9985.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.153.133] by mail.gmx.net (mp024) with SMTP; 04 Jan 2013 10:48:03 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX18GvVkcjv8Gdf1jebQXOAcIPUTahZtM5WJnKp+m2V tYFYMteR9EV+i3 In-Reply-To: (Stefan Monnier's message of "Thu, 03 Jan 2013 11:28:32 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156076 Archived-At: Stefan Monnier writes: > But I don't see anything in the patch which checks that `round' returned > the right value (i.e. we now always return integers and never floats, > even if the value is too large to be represented as an integer). Hmm, yes. I've committed a modified version of the patch to emacs-24, which should DTRT. > Stefan Best regards, Michael.