From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to Date: Thu, 03 Jan 2013 11:28:32 -0500 Message-ID: References: <87y5gfyh3p.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1357230522 32732 80.91.229.3 (3 Jan 2013 16:28:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Jan 2013 16:28:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 03 17:28:58 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tqnf3-0001oH-5p for ged-emacs-devel@m.gmane.org; Thu, 03 Jan 2013 17:28:53 +0100 Original-Received: from localhost ([::1]:40259 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqneo-0003k6-2o for ged-emacs-devel@m.gmane.org; Thu, 03 Jan 2013 11:28:38 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:42417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqnel-0003jp-Fn for emacs-devel@gnu.org; Thu, 03 Jan 2013 11:28:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tqnek-0007eG-6L for emacs-devel@gnu.org; Thu, 03 Jan 2013 11:28:35 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:17661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tqnek-0007eB-2g; Thu, 03 Jan 2013 11:28:34 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtkGAG6Zu09FxK5W/2dsb2JhbABEgXuyFoEIghUBAQQBViMFCws0BwsUGA0kiBwFC7l+kEQDiEKNaI0JgViDBw X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="211279176" Original-Received: from 69-196-174-86.dsl.teksavvy.com (HELO pastel.home) ([69.196.174.86]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Jan 2013 11:28:33 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id B4E1E58FAD; Thu, 3 Jan 2013 11:28:32 -0500 (EST) In-Reply-To: <87y5gfyh3p.fsf@gmx.de> (Michael Albinus's message of "Sun, 30 Dec 2012 11:22:34 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.182 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:156058 Archived-At: >>> * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to >>> integers, if they are real numbers. (Bug#13282) >> Why is that TRT? Or more specifically, why do we get floats here? >> They should only happen when the number is too large to be represented >> as a fixnum. > That's exactly the reason. See . But I don't see anything in the patch which checks that `round' returned the right value (i.e. we now always return integers and never floats, even if the value is too large to be represented as an integer). Stefan