unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Colin Baxter <m43cap@yandex.com>
To: Stefan Kangas <stefan@marxist.se>
Cc: , "Paul W. Rankin" <pwr@bydasein.com>,
	"Paul W. Rankin via Emacs development discussions."
	<emacs-devel@gnu.org>, Karl Fogel <kfogel@red-bean.com>,
	Lars Ingebrigtsen <larsi@gnus.org>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
Date: Mon, 13 Sep 2021 11:12:07 +0100	[thread overview]
Message-ID: <87v934hjig.fsf@yandex.com> (raw)
In-Reply-To: <CADwFkm=hwDW3oUHZxpv6Y2Q2bErvA-Vrm=qVYUhzhKsK2mSd6Q@mail.gmail.com> (Stefan Kangas's message of "Mon, 13 Sep 2021 11:46:45 +0200")

>>>>> Stefan Kangas <stefan@marxist.se> writes:

    > [That was in May.]  Lars Ingebrigtsen <larsi@gnus.org> writes:

    >> Eli Zaretskii <eliz@gnu.org> writes:
    >> 
    >> > Please don't make this change until you hear from Lars, who
    >> examined > the original patch and decided to install it.  It
    >> doesn't get more > "considerate" than that.
    >> 
    >> It does seem to be an unexpectedly (to me, at least)
    >> controversial change, so perhaps it should be tweaked.  For
    >> instance, using fringe markers (on frames that support that)
    >> instead of highlighting the entire line, or something else that
    >> isn't that stark.

    > This discussion sort of fizzled out with everyone, as far as I can
    > tell, mostly agreeing that a fringe marker or similar might be
    > better for the default behaviour.  On master, bookmark-fontify is
    > still t, and the highlighting is still done by changing the
    > background colour.

    > In general, I think we are sometimes too cautious with turning on
    > so-called "bells and whistles", so I'm actually in one sense happy
    > to see that a useful new feature is enabled by default.  Yet I'm a
    > little surprised that this particular feature happened to pass the
    > bar.

    > I personally find that highlighting the entire line is fairly
    > distracting,

Me too. I use bookmark.el for a file, with bookmark-fontify set to nil,
but I use bm.el (<https://github.com/joodland/bm>) for a point in a
file. The advantage of bm.el is that the marker does not extend the
whole length of the line, which, for me, more than compensates the
inconvenience of using two different bookmark libraries.


Best wishes,



  parent reply	other threads:[~2021-09-13 10:12 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  6:20 [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Paul W. Rankin via Emacs development discussions.
2021-05-18  6:58 ` Karl Fogel
2021-05-18  8:17   ` Paul W. Rankin via Emacs development discussions.
2021-05-18  8:45     ` Eli Zaretskii
2021-05-18 10:06       ` Paul W. Rankin via Emacs development discussions.
2021-05-18 12:09         ` Eli Zaretskii
2021-05-18 12:04       ` Eli Zaretskii
2021-05-18 14:28       ` Lars Ingebrigtsen
2021-05-18 14:38         ` Eli Zaretskii
2021-05-18 14:40           ` Lars Ingebrigtsen
2021-05-19 11:59           ` Bastien
2021-05-19 13:55             ` Eli Zaretskii
2021-05-24 22:32             ` Lars Ingebrigtsen
2021-05-24 22:51               ` [External] : " Drew Adams
2021-05-18 14:43         ` Drew Adams
2021-05-18 15:07           ` Eli Zaretskii
2021-09-13  9:46         ` Stefan Kangas
2021-09-13  9:58           ` Manuel Uberti
2021-09-13 10:17             ` Stefan Kangas
2021-09-13 10:12           ` Colin Baxter [this message]
2021-09-13 15:29             ` [External] : " Drew Adams
2021-09-13 10:43           ` Adam Porter
2021-09-13 11:36           ` Lars Ingebrigtsen
2021-09-13 19:36             ` Matthias Meulien
2021-09-14  5:40               ` Colin Baxter
2021-09-14 11:15               ` Lars Ingebrigtsen
2021-09-14 11:46                 ` Eli Zaretskii
2021-09-14 11:54                   ` Lars Ingebrigtsen
2021-09-14 11:52                 ` miha
2021-09-14 11:56                   ` Lars Ingebrigtsen
2021-09-14 14:44                     ` miha
2021-09-15  7:59                       ` Lars Ingebrigtsen
2021-05-18 10:49     ` Basil L. Contovounesios
2021-05-18 11:08       ` Paul W. Rankin via Emacs development discussions.
2021-05-19 12:00       ` Bastien
2021-05-19 12:58         ` Gregor Zattler
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-19 12:00 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 14:15   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v934hjig.fsf@yandex.com \
    --to=m43cap@yandex.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kfogel@red-bean.com \
    --cc=larsi@gnus.org \
    --cc=pwr@bydasein.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).