unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>, Bastien <bzg@gnu.org>
Cc: "kfogel@red-bean.com" <kfogel@red-bean.com>,
	Eli Zaretskii <eliz@gnu.org>,
	"pwr@bydasein.com" <pwr@bydasein.com>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: RE: [External] : Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
Date: Mon, 24 May 2021 22:51:01 +0000	[thread overview]
Message-ID: <SA2PR10MB44741DD75CDF7DF37E5E947CF3269@SA2PR10MB4474.namprd10.prod.outlook.com> (raw)
In-Reply-To: <87k0nn9300.fsf@gnus.org>

> Ah, yes -- good point.  So a fringe marker seems like 
> the right thing here, I think.
> 
> > But we need to find some replacement for TTY frames then.
> 
> Well, we could just say that this isn't supported on TTYs.  Or...  we
> could use a text property on the single character where the bookmark is
> (normally the first character on a line), but that'd look pretty odd.

Dunno why you don't check what's done in Bookmark+.
It might present some food for thought, at least.

https://www.emacswiki.org/emacs/BookmarkPlus#HighlightingBookmarkLocations

Various kinds of highlighting are used.  Some of them
might be relevant for what you're trying to do.  Each
involves a style and possibly a face.

You've already started to consider fringe and buffer
position.

There are advantages to each kind of highlighting.
Those that use a face can (in principle) let users
tell the kind of bookmark from its face.  (That's
more important for Bookmark+, where you can have
different kinds of bookmark in the same buffer, for
different purposes.)

You might also check out the highlighting that bm.el
uses.

Just a suggestion.



  reply	other threads:[~2021-05-24 22:51 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  6:20 [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Paul W. Rankin via Emacs development discussions.
2021-05-18  6:58 ` Karl Fogel
2021-05-18  8:17   ` Paul W. Rankin via Emacs development discussions.
2021-05-18  8:45     ` Eli Zaretskii
2021-05-18 10:06       ` Paul W. Rankin via Emacs development discussions.
2021-05-18 12:09         ` Eli Zaretskii
2021-05-18 12:04       ` Eli Zaretskii
2021-05-18 14:28       ` Lars Ingebrigtsen
2021-05-18 14:38         ` Eli Zaretskii
2021-05-18 14:40           ` Lars Ingebrigtsen
2021-05-19 11:59           ` Bastien
2021-05-19 13:55             ` Eli Zaretskii
2021-05-24 22:32             ` Lars Ingebrigtsen
2021-05-24 22:51               ` Drew Adams [this message]
2021-05-18 14:43         ` [External] : " Drew Adams
2021-05-18 15:07           ` Eli Zaretskii
2021-09-13  9:46         ` Stefan Kangas
2021-09-13  9:58           ` Manuel Uberti
2021-09-13 10:17             ` Stefan Kangas
2021-09-13 10:12           ` Colin Baxter
2021-09-13 15:29             ` [External] : " Drew Adams
2021-09-13 10:43           ` Adam Porter
2021-09-13 11:36           ` Lars Ingebrigtsen
2021-09-13 19:36             ` Matthias Meulien
2021-09-14  5:40               ` Colin Baxter
2021-09-14 11:15               ` Lars Ingebrigtsen
2021-09-14 11:46                 ` Eli Zaretskii
2021-09-14 11:54                   ` Lars Ingebrigtsen
2021-09-14 11:52                 ` miha
2021-09-14 11:56                   ` Lars Ingebrigtsen
2021-09-14 14:44                     ` miha
2021-09-15  7:59                       ` Lars Ingebrigtsen
2021-05-18 10:49     ` Basil L. Contovounesios
2021-05-18 11:08       ` Paul W. Rankin via Emacs development discussions.
2021-05-19 12:00       ` Bastien
2021-05-19 12:58         ` Gregor Zattler
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-19 12:00 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 14:15   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA2PR10MB44741DD75CDF7DF37E5E947CF3269@SA2PR10MB4474.namprd10.prod.outlook.com \
    --to=drew.adams@oracle.com \
    --cc=bzg@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kfogel@red-bean.com \
    --cc=larsi@gnus.org \
    --cc=pwr@bydasein.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).