From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kfogel@red-bean.com, stefan@marxist.se, pwr@bydasein.com,
orontee@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
Date: Tue, 14 Sep 2021 13:54:01 +0200 [thread overview]
Message-ID: <871r5rwexy.fsf@gnus.org> (raw)
In-Reply-To: <83fsu7crbo.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Sep 2021 14:46:51 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> So the problem seems to be that a `revert-buffer' doesn't keep overlays
>> where they were, I guess? (Or remove the overlays, at least.)
>
> Are they removed, or do they move/evaporate because their markers
> move?
These overlays are zero-length, so they don't evaporate. But...
perhaps they shouldn't be, and be marked with `evaporate'? That should
make them go away in this case, at least. (I haven't really worked much
with fringe markers before...)
>> Do we have some machinery to handle overlays like this, or conventions
>> about what to do with overlays when doing a `revert-buffer' actions?
>
> AFAIK, we already try to preserve the buffer markers, if possible.
> And revert-buffer-with-fine-grain tries harder. So if the issue is
> that the overlays' markers moved, we already try.
But perhaps this doesn't work with zero-length overlays? (Those are
handled specially in many circumstances.)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-09-14 11:54 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 6:20 [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Paul W. Rankin via Emacs development discussions.
2021-05-18 6:58 ` Karl Fogel
2021-05-18 8:17 ` Paul W. Rankin via Emacs development discussions.
2021-05-18 8:45 ` Eli Zaretskii
2021-05-18 10:06 ` Paul W. Rankin via Emacs development discussions.
2021-05-18 12:09 ` Eli Zaretskii
2021-05-18 12:04 ` Eli Zaretskii
2021-05-18 14:28 ` Lars Ingebrigtsen
2021-05-18 14:38 ` Eli Zaretskii
2021-05-18 14:40 ` Lars Ingebrigtsen
2021-05-19 11:59 ` Bastien
2021-05-19 13:55 ` Eli Zaretskii
2021-05-24 22:32 ` Lars Ingebrigtsen
2021-05-24 22:51 ` [External] : " Drew Adams
2021-05-18 14:43 ` Drew Adams
2021-05-18 15:07 ` Eli Zaretskii
2021-09-13 9:46 ` Stefan Kangas
2021-09-13 9:58 ` Manuel Uberti
2021-09-13 10:17 ` Stefan Kangas
2021-09-13 10:12 ` Colin Baxter
2021-09-13 15:29 ` [External] : " Drew Adams
2021-09-13 10:43 ` Adam Porter
2021-09-13 11:36 ` Lars Ingebrigtsen
2021-09-13 19:36 ` Matthias Meulien
2021-09-14 5:40 ` Colin Baxter
2021-09-14 11:15 ` Lars Ingebrigtsen
2021-09-14 11:46 ` Eli Zaretskii
2021-09-14 11:54 ` Lars Ingebrigtsen [this message]
2021-09-14 11:52 ` miha
2021-09-14 11:56 ` Lars Ingebrigtsen
2021-09-14 14:44 ` miha
2021-09-15 7:59 ` Lars Ingebrigtsen
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-18 11:08 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 12:00 ` Bastien
2021-05-19 12:58 ` Gregor Zattler
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-19 12:00 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 14:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871r5rwexy.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=orontee@gmail.com \
--cc=pwr@bydasein.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).