From: Karl Fogel <kfogel@red-bean.com>
To: Emacs Devel <emacs-devel@gnu.org>
Cc: "Paul W. Rankin" <pwr@bydasein.com>
Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
Date: Tue, 18 May 2021 01:58:37 -0500 [thread overview]
Message-ID: <87k0nw1qaq.fsf@red-bean.com> (raw)
In-Reply-To: <1df50c0d035675f851387d689030d588@purelymail.com> (Paul W. Rankin's message of "Tue, 18 May 2021 16:20:29 +1000")
On 18 May 2021, Paul W. Rankin" via "Emacs development
discussions. wrote:
>Ugh. Not sure how this slipped into master but it is not a
>good/considerate idea to set default value of bookmark-fontify to
>t.
>
>If there are no reasonable objections I'll push this later today.
I don't have a strong opinion either way, but if you're curious as
to where this came from, it was here:
commit ab6cb65cb2b6d11a7b690dfcea8d98611290fad9
Author: Boruch Baum <boruch_baum@gmx.com>
AuthorDate: Tue May 4 10:58:52 2021 +0200
Commit: Lars Ingebrigtsen <larsi@gnus.org>
CommitDate: Tue May 4 10:58:52 2021 +0200
Fontify lines when setting a bookmark
* lisp/bookmark.el (bookmark-fontify): New user option
(bug#48179).
(bookmark-face): New face.
(bookmark--fontify, bookmark--unfontify): New functions.
(bookmark-set-internal, bookmark--jump-via,
bookmark-delete): Use
them.
The discussion in
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48179 is quite long,
so it might be worth reading before reverting.
Best regards,
-Karl
next prev parent reply other threads:[~2021-05-18 6:58 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 6:20 [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Paul W. Rankin via Emacs development discussions.
2021-05-18 6:58 ` Karl Fogel [this message]
2021-05-18 8:17 ` Paul W. Rankin via Emacs development discussions.
2021-05-18 8:45 ` Eli Zaretskii
2021-05-18 10:06 ` Paul W. Rankin via Emacs development discussions.
2021-05-18 12:09 ` Eli Zaretskii
2021-05-18 12:04 ` Eli Zaretskii
2021-05-18 14:28 ` Lars Ingebrigtsen
2021-05-18 14:38 ` Eli Zaretskii
2021-05-18 14:40 ` Lars Ingebrigtsen
2021-05-19 11:59 ` Bastien
2021-05-19 13:55 ` Eli Zaretskii
2021-05-24 22:32 ` Lars Ingebrigtsen
2021-05-24 22:51 ` [External] : " Drew Adams
2021-05-18 14:43 ` Drew Adams
2021-05-18 15:07 ` Eli Zaretskii
2021-09-13 9:46 ` Stefan Kangas
2021-09-13 9:58 ` Manuel Uberti
2021-09-13 10:17 ` Stefan Kangas
2021-09-13 10:12 ` Colin Baxter
2021-09-13 15:29 ` [External] : " Drew Adams
2021-09-13 10:43 ` Adam Porter
2021-09-13 11:36 ` Lars Ingebrigtsen
2021-09-13 19:36 ` Matthias Meulien
2021-09-14 5:40 ` Colin Baxter
2021-09-14 11:15 ` Lars Ingebrigtsen
2021-09-14 11:46 ` Eli Zaretskii
2021-09-14 11:54 ` Lars Ingebrigtsen
2021-09-14 11:52 ` miha
2021-09-14 11:56 ` Lars Ingebrigtsen
2021-09-14 14:44 ` miha
2021-09-15 7:59 ` Lars Ingebrigtsen
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-18 11:08 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 12:00 ` Bastien
2021-05-19 12:58 ` Gregor Zattler
2021-05-18 10:49 ` Basil L. Contovounesios
2021-05-19 12:00 ` Paul W. Rankin via Emacs development discussions.
2021-05-19 14:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0nw1qaq.fsf@red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-devel@gnu.org \
--cc=pwr@bydasein.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).