From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Colin Baxter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default Date: Mon, 13 Sep 2021 11:12:07 +0100 Message-ID: <87v934hjig.fsf@yandex.com> References: <1df50c0d035675f851387d689030d588@purelymail.com> <87k0nw1qaq.fsf@red-bean.com> <878s4cf74z.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33410"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Cc: , "Paul W. Rankin" , "Paul W. Rankin via Emacs development discussions." , Karl Fogel , Lars Ingebrigtsen , Eli Zaretskii To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 13 12:27:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPjB9-0008My-PD for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Sep 2021 12:27:11 +0200 Original-Received: from localhost ([::1]:50348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPjB8-0005nI-KV for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Sep 2021 06:27:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPiwn-0008Dx-4H for emacs-devel@gnu.org; Mon, 13 Sep 2021 06:12:21 -0400 Original-Received: from forward107p.mail.yandex.net ([2a02:6b8:0:1472:2741:0:8b7:115]:33850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPiwk-0007uR-6T; Mon, 13 Sep 2021 06:12:20 -0400 Original-Received: from iva5-8e573b7a3fc7.qloud-c.yandex.net (iva5-8e573b7a3fc7.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:5a18:0:640:8e57:3b7a]) by forward107p.mail.yandex.net (Yandex) with ESMTP id B5A8C556EACF; Mon, 13 Sep 2021 13:12:10 +0300 (MSK) Original-Received: from iva7-f62245f79210.qloud-c.yandex.net (iva7-f62245f79210.qloud-c.yandex.net [2a02:6b8:c0c:2e83:0:640:f622:45f7]) by iva5-8e573b7a3fc7.qloud-c.yandex.net (mxback/Yandex) with ESMTP id BrPGQGLZHA-CAEGqWM9; Mon, 13 Sep 2021 13:12:10 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1631527930; bh=c0yxsGN6EmfWnXurie+1T2S38gV2VctNN8CntGAOXyg=; h=In-Reply-To:Subject:Date:References:To:From:Message-ID:Cc:Cc; b=YI1G+g5EURhvFvavJ+bzp5B1civfaZC4GMyxcwz/C0Do5p4tVVo1ZhLNbE0o+Z8Sb 5bniTXrt2m7Cjd8KT64kO9WR2HmPoSeuoNvgz4gnRa6WzhGXtNUOhwW4BympwbTesm YgbGSKMSnTSYsTnGVMmDr/bYbVkjKttJ9Xf+kCRU= Authentication-Results: iva5-8e573b7a3fc7.qloud-c.yandex.net; dkim=pass header.i=@yandex.com Original-Received: by iva7-f62245f79210.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id SuQK8Yh6dF-C89GOerY; Mon, 13 Sep 2021 13:12:09 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) X-Face: BHjiJOg/Qmj'BQgsAKL@])L)e62P)C"Y=6T X-Message-My-Extra-Message: 8-) We are the only ones here =?utf-8?B?8J+YuiDwn5i6IPCfmLo=?= In-Reply-To: (Stefan Kangas's message of "Mon, 13 Sep 2021 11:46:45 +0200") Face: iVBORw0KGgoAAAANSUhEUgAAAEkAAAATAgMAAAChCMjeAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEX/zAABCWP///8I RHjYAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB+UFEAk5BvqS634A AAAbSURBVBjTY2BgCA1hYA0FAxDDgQEERsXoIAYA2F9Eb3cpB+AAAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjEtMDUtMTZUMTA6NTY6MTcrMDE6MDCh/kkpAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA1 LTE2VDA5OjU3OjA2KzAxOjAwTyZ6HwAAAABJRU5ErkJggg== Received-SPF: pass client-ip=2a02:6b8:0:1472:2741:0:8b7:115; envelope-from=m43cap@yandex.com; helo=forward107p.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274629 Archived-At: >>>>> Stefan Kangas writes: > [That was in May.] Lars Ingebrigtsen writes: >> Eli Zaretskii writes: >> >> > Please don't make this change until you hear from Lars, who >> examined > the original patch and decided to install it. It >> doesn't get more > "considerate" than that. >> >> It does seem to be an unexpectedly (to me, at least) >> controversial change, so perhaps it should be tweaked. For >> instance, using fringe markers (on frames that support that) >> instead of highlighting the entire line, or something else that >> isn't that stark. > This discussion sort of fizzled out with everyone, as far as I can > tell, mostly agreeing that a fringe marker or similar might be > better for the default behaviour. On master, bookmark-fontify is > still t, and the highlighting is still done by changing the > background colour. > In general, I think we are sometimes too cautious with turning on > so-called "bells and whistles", so I'm actually in one sense happy > to see that a useful new feature is enabled by default. Yet I'm a > little surprised that this particular feature happened to pass the > bar. > I personally find that highlighting the entire line is fairly > distracting, Me too. I use bookmark.el for a file, with bookmark-fontify set to nil, but I use bm.el () for a point in a file. The advantage of bm.el is that the marker does not extend the whole length of the line, which, for me, more than compensates the inconvenience of using two different bookmark libraries. Best wishes,