* Re: master 409f0430b6: Fix click position to menu bar entry with no-toolkit
[not found] ` <20221119002446.D53CCC00613@vcs2.savannah.gnu.org>
@ 2022-11-19 0:34 ` Sean Whitton
2022-11-19 4:36 ` Po Lu
0 siblings, 1 reply; 2+ messages in thread
From: Sean Whitton @ 2022-11-19 0:34 UTC (permalink / raw)
To: emacs-devel, Manuel Giraud, Po Lu
Hello,
On Fri 18 Nov 2022 at 07:24PM -05, Po Lu via Mailing list for Emacs changes wrote:
> branch: master
> commit 409f0430b6a0c138836e5067141bf6b2a7beb6b3
> Author: Manuel Giraud <manuel@ledu-giraud.fr>
> Commit: Po Lu <luangruo@yahoo.com>
>
> Fix click position to menu bar entry with no-toolkit
>
> * src/keyboard.c (make_lispy_event): Use x_y_to_hpos_vpos to
> compute correct menu bar position should the menu face change.
> * src/xdisp.c (x_y_to_hpos_vpos): Not static anymore.
> * src/dispextern.h: Export x_y_to_hpos_vpos.
Looks like this breaks the build:
keyboard.c: In function ‘make_lispy_event’:
keyboard.c:5980:43: error: ‘struct frame’ has no member named ‘menu_bar_window’; did you mean ‘tab_bar_window’?
5980 | struct window *menu_w = XWINDOW (f->menu_bar_window);
| ^~~~~~~~~~~~~~~
| tab_bar_window
keyboard.c:5986:37: error: ‘struct frame’ has no member named ‘menu_bar_window’; did you mean ‘tab_bar_window’?
5986 | x_y_to_hpos_vpos (XWINDOW (f->menu_bar_window), x, y, &column, &row,
| ^~~~~~~~~~~~~~~
| tab_bar_window
--
Sean Whitton
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 409f0430b6: Fix click position to menu bar entry with no-toolkit
2022-11-19 0:34 ` master 409f0430b6: Fix click position to menu bar entry with no-toolkit Sean Whitton
@ 2022-11-19 4:36 ` Po Lu
0 siblings, 0 replies; 2+ messages in thread
From: Po Lu @ 2022-11-19 4:36 UTC (permalink / raw)
To: Sean Whitton; +Cc: emacs-devel, Manuel Giraud
Sean Whitton <spwhitton@spwhitton.name> writes:
> Hello,
>
> On Fri 18 Nov 2022 at 07:24PM -05, Po Lu via Mailing list for Emacs changes wrote:
>
>> branch: master
>> commit 409f0430b6a0c138836e5067141bf6b2a7beb6b3
>> Author: Manuel Giraud <manuel@ledu-giraud.fr>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>> Fix click position to menu bar entry with no-toolkit
>>
>> * src/keyboard.c (make_lispy_event): Use x_y_to_hpos_vpos to
>> compute correct menu bar position should the menu face change.
>> * src/xdisp.c (x_y_to_hpos_vpos): Not static anymore.
>> * src/dispextern.h: Export x_y_to_hpos_vpos.
>
> Looks like this breaks the build:
>
> keyboard.c: In function ‘make_lispy_event’:
> keyboard.c:5980:43: error: ‘struct frame’ has no member named ‘menu_bar_window’; did you mean ‘tab_bar_window’?
> 5980 | struct window *menu_w = XWINDOW (f->menu_bar_window);
> | ^~~~~~~~~~~~~~~
> | tab_bar_window
> keyboard.c:5986:37: error: ‘struct frame’ has no member named ‘menu_bar_window’; did you mean ‘tab_bar_window’?
> 5986 | x_y_to_hpos_vpos (XWINDOW (f->menu_bar_window), x, y, &column, &row,
> | ^~~~~~~~~~~~~~~
> | tab_bar_window
I will fix that shortly, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-19 4:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166881748628.7930.11644106632346699072@vcs2.savannah.gnu.org>
[not found] ` <20221119002446.D53CCC00613@vcs2.savannah.gnu.org>
2022-11-19 0:34 ` master 409f0430b6: Fix click position to menu bar entry with no-toolkit Sean Whitton
2022-11-19 4:36 ` Po Lu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).