From: Po Lu <luangruo@yahoo.com>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: emacs-devel@gnu.org, Manuel Giraud <manuel@ledu-giraud.fr>
Subject: Re: master 409f0430b6: Fix click position to menu bar entry with no-toolkit
Date: Sat, 19 Nov 2022 12:36:15 +0800 [thread overview]
Message-ID: <87v8nbblxc.fsf@yahoo.com> (raw)
In-Reply-To: <87o7t3kcim.fsf@melete.silentflame.com> (Sean Whitton's message of "Fri, 18 Nov 2022 17:34:41 -0700")
Sean Whitton <spwhitton@spwhitton.name> writes:
> Hello,
>
> On Fri 18 Nov 2022 at 07:24PM -05, Po Lu via Mailing list for Emacs changes wrote:
>
>> branch: master
>> commit 409f0430b6a0c138836e5067141bf6b2a7beb6b3
>> Author: Manuel Giraud <manuel@ledu-giraud.fr>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>> Fix click position to menu bar entry with no-toolkit
>>
>> * src/keyboard.c (make_lispy_event): Use x_y_to_hpos_vpos to
>> compute correct menu bar position should the menu face change.
>> * src/xdisp.c (x_y_to_hpos_vpos): Not static anymore.
>> * src/dispextern.h: Export x_y_to_hpos_vpos.
>
> Looks like this breaks the build:
>
> keyboard.c: In function ‘make_lispy_event’:
> keyboard.c:5980:43: error: ‘struct frame’ has no member named ‘menu_bar_window’; did you mean ‘tab_bar_window’?
> 5980 | struct window *menu_w = XWINDOW (f->menu_bar_window);
> | ^~~~~~~~~~~~~~~
> | tab_bar_window
> keyboard.c:5986:37: error: ‘struct frame’ has no member named ‘menu_bar_window’; did you mean ‘tab_bar_window’?
> 5986 | x_y_to_hpos_vpos (XWINDOW (f->menu_bar_window), x, y, &column, &row,
> | ^~~~~~~~~~~~~~~
> | tab_bar_window
I will fix that shortly, thanks.
prev parent reply other threads:[~2022-11-19 4:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166881748628.7930.11644106632346699072@vcs2.savannah.gnu.org>
[not found] ` <20221119002446.D53CCC00613@vcs2.savannah.gnu.org>
2022-11-19 0:34 ` master 409f0430b6: Fix click position to menu bar entry with no-toolkit Sean Whitton
2022-11-19 4:36 ` Po Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8nbblxc.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=manuel@ledu-giraud.fr \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).