From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: master 409f0430b6: Fix click position to menu bar entry with no-toolkit Date: Fri, 18 Nov 2022 17:34:41 -0700 Message-ID: <87o7t3kcim.fsf@melete.silentflame.com> References: <166881748628.7930.11644106632346699072@vcs2.savannah.gnu.org> <20221119002446.D53CCC00613@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13901"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org, Manuel Giraud , Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 19 01:35:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owBpW-0003Hc-Hi for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Nov 2022 01:35:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owBor-0004Hd-Hc; Fri, 18 Nov 2022 19:34:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owBop-0004HQ-WC for emacs-devel@gnu.org; Fri, 18 Nov 2022 19:34:52 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owBok-0008R5-Al for emacs-devel@gnu.org; Fri, 18 Nov 2022 19:34:51 -0500 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9282F5C00DD; Fri, 18 Nov 2022 19:34:43 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 18 Nov 2022 19:34:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1668818083; x= 1668904483; bh=jGYBoZ01Srv67hm1VhQ1v7OLZKX4jno4JyU0rKsj8A0=; b=Y RclLkaUoZ6n173TRR/oeQRysuiCjxwyZPLV0ew9JZyfg92iaWZhv5Gl0ExWLKaMw rg7THuypaXIJxM9oKrwjQjUk5OqBGxQl6kAlJFOGX/QdR9C9yLToL+ICyIj/CyLE oaztaTPzWO6BnN8OzMHvFOMZoztG1Mbhh7ww+GZH23FIgouKGIzW4ELQS3mN7iYh BaOZUgSsxsrz+rjsMa9OpLt1SJyLMd3LWJ8K2p0ffb0HswBQmoMTUUky2bUhMMlS 7L1AW6WoSSBjObMLEVavkftp41uoae/8iLyXzdXbauxnt379devO137AABiGeouG 8Gu9xAmgHBmB7qfTIff/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1668818083; x=1668904483; bh=j GYBoZ01Srv67hm1VhQ1v7OLZKX4jno4JyU0rKsj8A0=; b=w3dLBMIHtft7cpEK2 yxuMJCFeyRNGQdfobrVfCotVQOCK0NOw58Lf6YOTbI2Pkan7TC9bPGNQSDhPfVJJ MVKm5XRqJ4oMjjGDvg1cBJr9pqGRk3lppyje0hWlE7iDcA0WJY+Z4S5LQwE2RZZE 8VAKWAMmkVDE31NMRxWwMoUHTRdkxv6v1LBrgWKfoiYCyIhrN3sFkZz9vGXioC3H 126UUfkYtg2AC1zv8QY0keQEU+GoE5TYnxXE5/8gPpfCsxPO7d6wvpsRn68hJ6A4 MxQBGSReLYnEMfTGsRis4nxh3gKuhn1UF1m1PeIL46cvk2++TnD6BmTUkrSjfpf0 5/Kmw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedugddvgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkfgggtgfgsehtqhdttddtreejnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepudfgheeltdfggeekvdduteehffdvvdefgeevudelheehgfeg hefhhfevkeetjeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Nov 2022 19:34:43 -0500 (EST) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id E915C7E9185; Fri, 18 Nov 2022 17:34:41 -0700 (MST) In-Reply-To: <20221119002446.D53CCC00613@vcs2.savannah.gnu.org> (Po Lu via Mailing list for Emacs changes's message of "Fri, 18 Nov 2022 19:24:46 -0500 (EST)") Received-SPF: pass client-ip=66.111.4.26; envelope-from=spwhitton@spwhitton.name; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300129 Archived-At: Hello, On Fri 18 Nov 2022 at 07:24PM -05, Po Lu via Mailing list for Emacs changes= wrote: > branch: master > commit 409f0430b6a0c138836e5067141bf6b2a7beb6b3 > Author: Manuel Giraud > Commit: Po Lu > > Fix click position to menu bar entry with no-toolkit > > * src/keyboard.c (make_lispy_event): Use x_y_to_hpos_vpos to > compute correct menu bar position should the menu face change. > * src/xdisp.c (x_y_to_hpos_vpos): Not static anymore. > * src/dispextern.h: Export x_y_to_hpos_vpos. Looks like this breaks the build: keyboard.c: In function =E2=80=98make_lispy_event=E2=80=99: keyboard.c:5980:43: error: =E2=80=98struct frame=E2=80=99 has no member= named =E2=80=98menu_bar_window=E2=80=99; did you mean =E2=80=98tab_bar_win= dow=E2=80=99? 5980 | struct window *menu_w =3D XWINDOW (f->menu_bar_window); | ^~~~~~~~~~~~~~~ | tab_bar_window keyboard.c:5986:37: error: =E2=80=98struct frame=E2=80=99 has no member= named =E2=80=98menu_bar_window=E2=80=99; did you mean =E2=80=98tab_bar_win= dow=E2=80=99? 5986 | x_y_to_hpos_vpos (XWINDOW (f->menu_bar_window), x, y, &co= lumn, &row, | ^~~~~~~~~~~~~~~ | tab_bar_window --=20 Sean Whitton