From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 409f0430b6: Fix click position to menu bar entry with no-toolkit Date: Sat, 19 Nov 2022 12:36:15 +0800 Message-ID: <87v8nbblxc.fsf@yahoo.com> References: <166881748628.7930.11644106632346699072@vcs2.savannah.gnu.org> <20221119002446.D53CCC00613@vcs2.savannah.gnu.org> <87o7t3kcim.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22340"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, Manuel Giraud To: Sean Whitton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 19 05:37:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owFbR-0005bO-I7 for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Nov 2022 05:37:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owFai-0007yr-QW; Fri, 18 Nov 2022 23:36:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owFah-0007yj-3T for emacs-devel@gnu.org; Fri, 18 Nov 2022 23:36:31 -0500 Original-Received: from sonic307-10.consmr.mail.ne1.yahoo.com ([66.163.190.33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owFaf-0001aA-01 for emacs-devel@gnu.org; Fri, 18 Nov 2022 23:36:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668832585; bh=usXuYPR8nbcBDf+5862/FOYPE8O/7rTmQ4OabhrIxNc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=S4VVM34e0Xs+hLJD+9/SwRlrqeaYdaVnEN1zWPRBx7CjrXdRCJGKM4SinGxL9AFHrQrcZY2q1Ld/Cs6IxHEbfwm6QDQDbsu2AlcH1yqlvYn/zA2ULjLFcJgEVUoRENHjZUO4hvRu+t5iHqsmDSWb9fruklGbvjqOfidI3kFiR4DD56T5EZuFQeSbfKl7N3oUes3thBp3IdG1nKR9VKYox9hMpdYccrDOe4DPQMvt9fAvBBhfW32PZRrh+TElURPy8N+KVrC1CRKXhuKFLSDU1u4WzJoJTL+ZCgJ+e3Nx39BdGstb1iLtKliZyCnV9Uj3PL0UZYlfU0vU0JwbiiVfoQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668832585; bh=II0Vs2BwvzQsX5jcVSy0U1+A14defXFGBqCD4m3x852=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=AG1elsR5OlnyzDQp6eziTmWIcpqzvcfmD8sAEx2RrJ2gu87QEO1pEFwlMGdjWY8cvaEhFHOJ0MNT9wf9g1L8lD4CL4MMqEshhbT4O+xcvtJeMYz7HFxGl06NHkPr+YAzIoIZVZV5hFSk6Whw9/OxFUb5/VXANUjal7EgWeoixerX7L9icyDEaHebVWvlySGa/OS0KJeYTHOcAC4SMM2c8dXYCL1gfnl9HoVrfUqCYXtRu1wHG/0lGCCGNXQYTc5T8uB3SxWrF2kGTfInvUS9sVgpQc9dH5jmaLDdMeLEiB/b0dbU2CGACRj4gcPgkUj/RJc4SIKUdRAFaMStiW2z3w== X-YMail-OSG: SkyArZAVM1kNwl1VSlnW7RWiskxj4WtodRdgY61VjSALXx8g0SQpChv7ORkZz90 3ti4Ux2PsTWviyEPYeKUhNEiJLU3LPxoBRAZ7Fk9MI_gnMYxI1DWMTylg_S5l1R3_VeznQM2SxQx 7CdZ2lAN4IaP3LcMW1qH.RBgHwns6bC.9IP0gF54GrdxjOnO0lG5FNrn8CMTswPRw1LzU8kAeZiW Ba41Fob6T7oCRodnJkwS96_k3WQ72Gz.F5k4Od9blkAC3KoKFuLrCzU5kCSH18wRvzQ5GoYxrIN. 9CAs_1yyp3Dc.Ks9IJdjWQhLfYvMwVk0LvVuoErGSSxzjm3LNWT2_SFlWOndWMgHVUjdbN6Fuu0Y gcy7AvDbm41gCU5Z.Nt1AcUhH_8GRgs69w_0OkQ7Ej5w5rbjPp3PO56d8IBJqYHUP3dC0pBwgXM9 Sh9NwLm9ZWB8CwDwi5lrIHFzO7Ov21fwLFlsR7xORYrpgAGrQvfxy5lFVQqyRJbLRwf00veCGjpw xPyI87LDkpePXD4j2Hi_EQ49vGIO2LgkyEq4qsOKUNBX1YXK.JrqrDiNfmLf6xpGyGI_cDRd8x_v o16rRT4ahSvUOVJnA9sdfKUGGb9Kty7KBm32lJOUt9pa.pXDZ9wAKSxemrBSVXy3orzmr1aM7n6C OypyuXd.ffEEnuosyhRPeE4tEcw9NULjOpjEoPDef3k1Ije5Iyeo0O3E3PwwSAyXmNFDA6n7gqj4 .zqqm.ZnWrnSI.t1.R_jd4TWhbTLBwJJpEHr5PhKeZps0zsRBrmUkbEZb4JZxzmRi4OCUxLXfEA6 pfpvDrJuarVJR37wqq2enOKq0NBS8z4Z7gMmIPsuxg X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sat, 19 Nov 2022 04:36:25 +0000 Original-Received: by hermes--production-sg3-6c8895b545-26lc9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 9da5ff8679bd8391b47cf9cdca8f0439; Sat, 19 Nov 2022 04:36:21 +0000 (UTC) In-Reply-To: <87o7t3kcim.fsf@melete.silentflame.com> (Sean Whitton's message of "Fri, 18 Nov 2022 17:34:41 -0700") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.190.33; envelope-from=luangruo@yahoo.com; helo=sonic307-10.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300133 Archived-At: Sean Whitton writes: > Hello, > > On Fri 18 Nov 2022 at 07:24PM -05, Po Lu via Mailing list for Emacs chang= es wrote: > >> branch: master >> commit 409f0430b6a0c138836e5067141bf6b2a7beb6b3 >> Author: Manuel Giraud >> Commit: Po Lu >> >> Fix click position to menu bar entry with no-toolkit >> >> * src/keyboard.c (make_lispy_event): Use x_y_to_hpos_vpos to >> compute correct menu bar position should the menu face change. >> * src/xdisp.c (x_y_to_hpos_vpos): Not static anymore. >> * src/dispextern.h: Export x_y_to_hpos_vpos. > > Looks like this breaks the build: > > keyboard.c: In function =E2=80=98make_lispy_event=E2=80=99: > keyboard.c:5980:43: error: =E2=80=98struct frame=E2=80=99 has no memb= er named =E2=80=98menu_bar_window=E2=80=99; did you mean =E2=80=98tab_bar_w= indow=E2=80=99? > 5980 | struct window *menu_w =3D XWINDOW (f->menu_bar_window); > | ^~~~~~~~~~~~~~~ > | tab_bar_window > keyboard.c:5986:37: error: =E2=80=98struct frame=E2=80=99 has no memb= er named =E2=80=98menu_bar_window=E2=80=99; did you mean =E2=80=98tab_bar_w= indow=E2=80=99? > 5986 | x_y_to_hpos_vpos (XWINDOW (f->menu_bar_window), x, y, &= column, &row, > | ^~~~~~~~~~~~~~~ > | tab_bar_window I will fix that shortly, thanks.