unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Engster <deng@randomsample.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Eric M. Ludlam" <eric@siege-engine.com>,
	emacs-devel@gnu.org, Jorgen Schaefer <forcer@forcix.cx>,
	John Yates <john@yates-sheets.org>
Subject: Re: A unified project root interface
Date: Wed, 20 Mar 2013 17:34:09 +0100	[thread overview]
Message-ID: <87ppyurpxa.fsf@engster.org> (raw)
In-Reply-To: <jwvppyu2pv8.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 20 Mar 2013 08:57:16 -0400")

Stefan Monnier writes:
>>> That might require splitting EIEIO, or some other approach, maybe,
>>> I don't know.
>> I don't think that's a practical approach. In EDE, a project *is* a
>> class.
>
> [ Actually, there are various reasons to split EIEIO, one of them would
>   be to try and fix the eval-and-compile mess.  ]

What do you mean by "splitting EIEIO"? Into what parts?

>> I would however like to ask if such a 'project-root' feature is
>> absolutely needed right at startup time. I'm not sure about the overhead
>> involved when loading files, which might be annoying to people who don't
>> need it. OTOH, we already have vc-find-file-hook enabled by default,
>> which I guess renders such questions moot...
>
> Right, one possible approach is to try and delay the use of
> project-root, as is done for VC: have a preloaded ede-hooks.el file
> which is just enough to try and detect projects that use EDE, and then
> only load EDE if/when opening a file in such a project.

This won't work; you cannot detect whether a file is part of a project
without the project's definition (which comes in the form of a class, as
I've already written). It's a chicken/egg thing. Yes, there are projects
which save their state in a file 'Project.ede'; these could be detected,
but that's a special case.

So again, if such a 'project-root' feature is needed at startup, EDE is
out. Separating EDE from EIEIO would mean rewriting it.

Instead, I'd vote for a very simple approach which at least takes EDE
projects into account, among other things. Roughly like this:

(defun project-root-ede (file)
  (when (and (featurep' ede)
             (with-current-buffer file
               ede-object-root-project))
    ... return EDE root ... ))

(defun project-root-vc (file)
  (when (vc-file-registered file)
    ... return root from VC ... ))

(defvar project-root-detect-functions 
          '(project-root-ede project-root-vc))

(defun project-root ()
   (run-hook-with-args-until-success
       project-root-detect-functions
       (buffer-file-name (current-buffer))))

-David



  parent reply	other threads:[~2013-03-20 16:34 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-09 16:44 A unified project root interface Jorgen Schaefer
2013-03-09 17:12 ` Fabian Ezequiel Gallina
2013-03-10  5:38 ` Stefan Monnier
2013-03-10 10:06   ` Jorgen Schaefer
2013-03-11 18:57   ` Lluís
2013-03-12 23:28     ` Eric M. Ludlam
2013-03-12 23:42       ` Jorgen Schaefer
2013-03-13  2:02         ` Eric M. Ludlam
2013-03-13 18:03       ` David Engster
2013-03-13 19:11         ` Sudish Joseph
2013-03-16  0:47         ` Eric M. Ludlam
2013-03-16 14:18           ` David Engster
2013-03-16 15:02             ` Jorgen Schaefer
2013-03-16 22:27               ` Phil Hagelberg
2013-03-16 22:59               ` David Engster
2013-03-16 23:16                 ` Jorgen Schaefer
2013-03-17 17:40                   ` David Engster
2013-03-17 18:18                     ` Jorgen Schaefer
2013-03-18 22:50                       ` David Engster
2013-03-19  1:57                         ` John Yates
2013-03-19  7:18                           ` David Engster
2013-03-19 12:23                             ` Eric M. Ludlam
2013-03-19 13:06                             ` Stefan Monnier
2013-03-19 19:09                               ` David Engster
2013-03-20  3:21                                 ` Stefan Monnier
2013-03-20  4:48                                   ` Leo Liu
2013-03-20  7:04                                     ` joakim
2013-03-20  7:05                                     ` David Engster
2013-03-20  7:13                                   ` David Engster
2013-03-20 12:57                                     ` Stefan Monnier
2013-03-20 16:14                                       ` Davis Herring
2013-03-20 17:41                                         ` Stefan Monnier
2013-03-20 17:48                                         ` Stefan Monnier
2013-03-20 18:20                                         ` Bruce Korb
2013-03-20 22:14                                           ` Stefan Monnier
2013-03-20 16:34                                       ` David Engster [this message]
2013-03-20 17:47                                         ` Stefan Monnier
2013-03-21  0:55                                           ` Eric M. Ludlam
2013-03-21  3:27                                             ` Stefan Monnier
2013-03-21  4:07                                               ` Eric M. Ludlam
2013-03-21 14:33                                                 ` Stefan Monnier
2013-03-22  2:12                                                 ` Eric M. Ludlam
2013-03-23 11:04                                                   ` EIEIO split (was: A unified project root interface) David Engster
2013-03-21 16:32                                             ` A unified project root interface David Engster
2013-03-22  0:47                                               ` Eric M. Ludlam
2013-03-22 20:30                                                 ` David Engster
2013-03-23 17:10                                                   ` Eric M. Ludlam
2013-03-23 17:26                                                     ` Jorgen Schaefer
2013-03-23 18:02                                                       ` Dmitry Gutov
2013-03-23 20:51                                                         ` Pascal J. Bourguignon
2013-03-24  4:25                                                           ` Dmitry Gutov
2013-03-24 10:13                                                             ` Jorgen Schaefer
2013-04-06 13:25                                                               ` Jorgen Schaefer
2013-04-06 17:13                                                                 ` Eric M. Ludlam
2013-04-08 19:03                                                                   ` David Engster
2013-12-31 20:12                                                               ` Daniel Colascione
2013-03-20 17:49                                         ` Jorgen Schaefer
2013-03-19  7:33                         ` Jorgen Schaefer
2013-03-17  8:08                 ` joakim
2013-03-12 15:34   ` Sudish Joseph
2013-03-12 16:51     ` Dmitry Gutov
2013-03-12 18:23   ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppyurpxa.fsf@engster.org \
    --to=deng@randomsample.de \
    --cc=emacs-devel@gnu.org \
    --cc=eric@siege-engine.com \
    --cc=forcer@forcix.cx \
    --cc=john@yates-sheets.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).