unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Matthias Meulien <orontee@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Name of buffers created by project-shell
Date: Tue, 23 Mar 2021 21:08:11 +0100	[thread overview]
Message-ID: <87h7l163bo.fsf@gmail.com> (raw)
In-Reply-To: <e368df30-68d1-80d9-70a2-3b42ce5185bd@yandex.ru> (Dmitry Gutov's message of "Sun, 21 Mar 2021 21:44:19 +0200")

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 15.03.2021 02:41, Dmitry Gutov wrote:
>>> I think there's a problem even without using C-u:
>>>
>>> `project-shell' from a buffer whose associated project root path is
>>> /src/project1 creates a buffer named *shell*.
>>>
>>> Then `project-shell' from a buffer whose associated project root path is
>>> /src/project2 creates a buffer named *shell*<project2> (I am using the
>>> default `post-forward-angle-brackets' for `uniquify-buffer-name-style').
>>>
>>> But the uniquify rationalize mecanism doesn't rename the first buffer to
>>> *shell*<project1> which happens to be the case for buffers visiting
>>> files...
>> Yup, that's another bug. It should also how up for vc-dir buffers
>> too.
>
> Actually, it didn't occur for vc-dir buffers. So it's arguably a bug
> in my code.
>
> Attaching the updated patch which fixes that particular problem,
> though I'm a little more suspicious of some of uniquify's choices now.

I confirm that with that patch names of buffers created using
`project-shell' (without using C-u) are correct.
-- 
Matthias



  reply	other threads:[~2021-03-23 20:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02 21:18 Name of buffers created by project-shell Matthias Meulien
2021-03-04  3:21 ` Dmitry Gutov
2021-03-04  4:03   ` Stefan Monnier
2021-03-04 17:50   ` Juri Linkov
2021-03-05 14:22     ` Dmitry Gutov
2021-03-14 13:46   ` Matthias Meulien
2021-03-15  0:41     ` Dmitry Gutov
2021-03-15 13:05       ` Matthias Meulien
2021-03-21 19:44       ` Dmitry Gutov
2021-03-23 20:08         ` Matthias Meulien [this message]
2021-03-24 20:12           ` Juri Linkov
2021-03-24 20:47             ` Dmitry Gutov
2021-05-08 17:09         ` Matthias Meulien
2021-05-10  0:08           ` Dmitry Gutov
2021-03-14 13:56   ` Matthias Meulien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7l163bo.fsf@gmail.com \
    --to=orontee@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).