From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.devel Subject: Re: Name of buffers created by project-shell Date: Tue, 23 Mar 2021 21:08:11 +0100 Message-ID: <87h7l163bo.fsf@gmail.com> References: <87czwh9rv9.fsf@gmail.com> <87zgz526gx.fsf@gmail.com> <80c15296-ebf7-3030-993f-ffb01051d570@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3037"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 23 21:09:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lOnL0-0000ht-7z for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Mar 2021 21:09:14 +0100 Original-Received: from localhost ([::1]:48604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOnKz-0007pM-7q for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Mar 2021 16:09:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45282) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOnK5-0006sa-VL for emacs-devel@gnu.org; Tue, 23 Mar 2021 16:08:17 -0400 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:44593) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lOnK4-0004vY-5M for emacs-devel@gnu.org; Tue, 23 Mar 2021 16:08:17 -0400 Original-Received: by mail-wm1-x331.google.com with SMTP id j4-20020a05600c4104b029010c62bc1e20so21644wmi.3 for ; Tue, 23 Mar 2021 13:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=O+rI3PWMH5RllXaYt4d8wb3lR0sSUH5EzJXaKtDWg0Y=; b=F0WUWtkkFOVdS4k3yYoO9dtDpknnKQFRhXVgM6BXAoGVnFRCJO5PDatauLqGIhu7jB QBtVonoQXYEPvmnexeS6vFKay4RA6d6XVIdGwAWQqjiu3OKTUdbXxRThe9wyY6nFrWO1 lr0sSG4+yGnIhNT74ASFWS4ZxicX0NLuDxiEWMIJUcutyhO2Ec7r8h+oqqFqABPNNe89 sc3R+N4YKmWQghpVKfoa7j61A3sjcJYlvU6UKgNnodh+yOWjeaQeN+faxvNGIgj/rwL/ ZvBZ7SuXtKKbc5anwf2fM3iNoPFu/6/lb0mLmp4gv8LKH7kPF2xMZ31yUspFMRO3BbgA VdDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=O+rI3PWMH5RllXaYt4d8wb3lR0sSUH5EzJXaKtDWg0Y=; b=NCqOSVDS85SltS8faXJikKRzq6tPtESTip7o66gbf4ndi1a1RJEXCbUFQWI8vsR3AR x6MpNQEHmPVJLquBz51Ur0pIf9GIrIZK+r0Kvcl8wax56rSyUwxLY2bJhIKceTCHES4g AAT5Iojy+Oc43egXxHMLcETm04dwPKdpkfLfzEdX301ka5EeH/SroyM0aOnol+Ek1aTs cW+0cVB6xPnUcEvt/4iR+phRvxlBGhr+pEfN/gscA1SjAOgZbHbx3AuASFAn5klH4/KC 48SkGLJepuKa+bvUpyxn4naIseuyXGmG37r6QJ1i1xQG0phSI5DvGjbqWXKk48RWTWIM +OKQ== X-Gm-Message-State: AOAM530vRXge4ACj5p26sQKQsg5n7MKgkANiiMbbQGphSm7clW0eLkFw 7PUQ9bfH+IKhnUU1mp18Nmr7vOJgfZw= X-Google-Smtp-Source: ABdhPJyEUS3XJ/xVYsrxa6HlNGBcdohsT+zgNPU/NGOV7HQByxsG55v+bw8TwzBpA7fBnzR8e+yA1w== X-Received: by 2002:a05:600c:1550:: with SMTP id f16mr4864756wmg.97.1616530092583; Tue, 23 Mar 2021 13:08:12 -0700 (PDT) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id t14sm24280901wru.64.2021.03.23.13.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 13:08:12 -0700 (PDT) In-Reply-To: (Dmitry Gutov's message of "Sun, 21 Mar 2021 21:44:19 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=orontee@gmail.com; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266890 Archived-At: Dmitry Gutov writes: > On 15.03.2021 02:41, Dmitry Gutov wrote: >>> I think there's a problem even without using C-u: >>> >>> `project-shell' from a buffer whose associated project root path is >>> /src/project1 creates a buffer named *shell*. >>> >>> Then `project-shell' from a buffer whose associated project root path is >>> /src/project2 creates a buffer named *shell* (I am using the >>> default `post-forward-angle-brackets' for `uniquify-buffer-name-style'). >>> >>> But the uniquify rationalize mecanism doesn't rename the first buffer to >>> *shell* which happens to be the case for buffers visiting >>> files... >> Yup, that's another bug. It should also how up for vc-dir buffers >> too. > > Actually, it didn't occur for vc-dir buffers. So it's arguably a bug > in my code. > > Attaching the updated patch which fixes that particular problem, > though I'm a little more suspicious of some of uniquify's choices now. I confirm that with that patch names of buffers created using `project-shell' (without using C-u) are correct. -- Matthias