From: Matthias Meulien <orontee@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Name of buffers created by project-shell
Date: Sun, 14 Mar 2021 14:46:38 +0100 [thread overview]
Message-ID: <87zgz526gx.fsf@gmail.com> (raw)
In-Reply-To: <d54bd3e3-5c2b-dd74-f2b6-d078eca97e8a@yandex.ru> (Dmitry Gutov's message of "Thu, 4 Mar 2021 05:21:59 +0200")
> What you're asking for makes sense, but there is a snag because of how
> these commands are implemented.
>
> vc-dir doesn't choose the buffer name format itself. It ultimately
> calls create-file-buffer (which has an advice made by uniquify) which
> renames the buffer based on uniquify-buffer-name-style (if uniquify is
> loaded in the current session), of course. The problem with that
> function is that it always creates a new buffer. So, before calling
> it, vc-dir-prepare-status-buffer does a search for existing buffer and
> can find existing one if it matches by major mode and default
> directory.
Thanks Dmitry, I had forgotten that users have different settings for
uniquify-buffer-name-style variable...
> Both shell and eshell buffers can change their default-directory, but
> we can track which project they belong to with a new variable. See the
> attached patch.
Thanks! I am testing it.
I am not an eshell user but I guess the patch should use the variable
`eshell-buffer-name' defined in eshell.el in place of the hardcoded
"*eshell*" string.
> There's one problem, though: when called with C-u, the piece of
> behavior which reads as "create a new inferior shell buffer even if
> one already exists" now creates buffers uniquely named according to
> uniquify's rules, which seems to mean
>
> *shell*
> emacs-master/*shell*
> vc/emacs-master/*shell*
>
> instead of what one might expect, like
>
> emacs-master/*shell*
> emacs-master/*shell*<2>
> emacs-master/*shell*<3>
>
I think there's a problem even without using C-u:
`project-shell' from a buffer whose associated project root path is
/src/project1 creates a buffer named *shell*.
Then `project-shell' from a buffer whose associated project root path is
/src/project2 creates a buffer named *shell*<project2> (I am using the
default `post-forward-angle-brackets' for `uniquify-buffer-name-style').
But the uniquify rationalize mecanism doesn't rename the first buffer to
*shell*<project1> which happens to be the case for buffers visiting
files...
--
Matthias
next prev parent reply other threads:[~2021-03-14 13:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 21:18 Name of buffers created by project-shell Matthias Meulien
2021-03-04 3:21 ` Dmitry Gutov
2021-03-04 4:03 ` Stefan Monnier
2021-03-04 17:50 ` Juri Linkov
2021-03-05 14:22 ` Dmitry Gutov
2021-03-14 13:46 ` Matthias Meulien [this message]
2021-03-15 0:41 ` Dmitry Gutov
2021-03-15 13:05 ` Matthias Meulien
2021-03-21 19:44 ` Dmitry Gutov
2021-03-23 20:08 ` Matthias Meulien
2021-03-24 20:12 ` Juri Linkov
2021-03-24 20:47 ` Dmitry Gutov
2021-05-08 17:09 ` Matthias Meulien
2021-05-10 0:08 ` Dmitry Gutov
2021-03-14 13:56 ` Matthias Meulien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgz526gx.fsf@gmail.com \
--to=orontee@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).