From: Dmitry Gutov <dgutov@yandex.ru>
To: Matthias Meulien <orontee@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Name of buffers created by project-shell
Date: Mon, 15 Mar 2021 02:41:03 +0200 [thread overview]
Message-ID: <80c15296-ebf7-3030-993f-ffb01051d570@yandex.ru> (raw)
In-Reply-To: <87zgz526gx.fsf@gmail.com>
On 14.03.2021 15:46, Matthias Meulien wrote:
>> Both shell and eshell buffers can change their default-directory, but
>> we can track which project they belong to with a new variable. See the
>> attached patch.
>
> Thanks! I am testing it.
>
> I am not an eshell user but I guess the patch should use the variable
> `eshell-buffer-name' defined in eshell.el in place of the hardcoded
> "*eshell*" string.
Makes sense.
> I think there's a problem even without using C-u:
>
> `project-shell' from a buffer whose associated project root path is
> /src/project1 creates a buffer named *shell*.
>
> Then `project-shell' from a buffer whose associated project root path is
> /src/project2 creates a buffer named *shell*<project2> (I am using the
> default `post-forward-angle-brackets' for `uniquify-buffer-name-style').
>
> But the uniquify rationalize mecanism doesn't rename the first buffer to
> *shell*<project1> which happens to be the case for buffers visiting
> files...
Yup, that's another bug. It should also how up for vc-dir buffers too.
To reiterate the choices at this point, we either implement special
buffer-naming scheme in project and give up on consistency with
project-vc and uniquify-buffer-name-style, or we try to fix both
problems we have found in uniquify so far.
In theory, the latter would be ideal, and uniquify has certainly been
lacking in developer attention. But I have no idea how much work that
entails. If you have time, help in that area would be very welcome.
Otherwise I'll have to add it to my list.
next prev parent reply other threads:[~2021-03-15 0:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 21:18 Name of buffers created by project-shell Matthias Meulien
2021-03-04 3:21 ` Dmitry Gutov
2021-03-04 4:03 ` Stefan Monnier
2021-03-04 17:50 ` Juri Linkov
2021-03-05 14:22 ` Dmitry Gutov
2021-03-14 13:46 ` Matthias Meulien
2021-03-15 0:41 ` Dmitry Gutov [this message]
2021-03-15 13:05 ` Matthias Meulien
2021-03-21 19:44 ` Dmitry Gutov
2021-03-23 20:08 ` Matthias Meulien
2021-03-24 20:12 ` Juri Linkov
2021-03-24 20:47 ` Dmitry Gutov
2021-05-08 17:09 ` Matthias Meulien
2021-05-10 0:08 ` Dmitry Gutov
2021-03-14 13:56 ` Matthias Meulien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80c15296-ebf7-3030-993f-ffb01051d570@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=orontee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).