* Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.
[not found] ` <20221014115724.B04FCC1AB4A@vcs2.savannah.gnu.org>
@ 2022-10-14 12:10 ` Po Lu
2022-10-14 12:58 ` Vibhav Pant
0 siblings, 1 reply; 3+ messages in thread
From: Po Lu @ 2022-10-14 12:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Vibhav Pant
Vibhav Pant <vibhavp@gmail.com> writes:
> branch: feature/comp-use-ctors
> commit 1b48e8dde5bfee65c036fbfdc32b68c9093c2e06
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
> src/comp.c: Use constructor expressions when possible.
>
> * src/comp.c:
> - Add declarations for creating constructor/initializer expressions
> when supported.
> - (emit_coerce): Use a struct constructor expression to create a
> Lisp_Object value instead of creating a new local variable.
> - emit_limple_call_ref: Emit a single constructor expression for
> initializing tmp_arr.
This is not how we write commit messages; it should be:
* src/comp.c: Add declarations for creating
constructor/initializer expressions when supported.
(emit_coerce): Use a struct constructor expression to create a
Lisp_Object value instead of creating a new local variable.
(emit_limple_call_ref): Emit a single constructor expression for
initializing tmp_arr.
Keep in mind that the commit message must also be filled to 64 columns.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.
2022-10-14 12:10 ` feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible Po Lu
@ 2022-10-14 12:58 ` Vibhav Pant
2022-10-14 13:11 ` Robert Pluim
0 siblings, 1 reply; 3+ messages in thread
From: Vibhav Pant @ 2022-10-14 12:58 UTC (permalink / raw)
To: Po Lu, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]
On Fri, 2022-10-14 at 20:10 +0800, Po Lu wrote:
> Vibhav Pant <vibhavp@gmail.com> writes:
>
> > branch: feature/comp-use-ctors
> > commit 1b48e8dde5bfee65c036fbfdc32b68c9093c2e06
> > Author: Vibhav Pant <vibhavp@gmail.com>
> > Commit: Vibhav Pant <vibhavp@gmail.com>
> >
> > src/comp.c: Use constructor expressions when possible.
> >
> > * src/comp.c:
> > - Add declarations for creating constructor/initializer
> > expressions
> > when supported.
> > - (emit_coerce): Use a struct constructor expression to
> > create a
> > Lisp_Object value instead of creating a new local variable.
> > - emit_limple_call_ref: Emit a single constructor expression
> > for
> > initializing tmp_arr.
>
> This is not how we write commit messages; it should be:
>
> * src/comp.c: Add declarations for creating
> constructor/initializer expressions when supported.
> (emit_coerce): Use a struct constructor expression to create a
> Lisp_Object value instead of creating a new local variable.
> (emit_limple_call_ref): Emit a single constructor expression for
> initializing tmp_arr.
>
> Keep in mind that the commit message must also be filled to 64
> columns.
Ah, knew something about it was off. Thanks :)
--
Vibhav Pant
vibhavp@gmail.com
GPG: 7ED1 D48C 513C A024 BE3A 785F E3FB 28CB 6AB5 9598
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.
2022-10-14 12:58 ` Vibhav Pant
@ 2022-10-14 13:11 ` Robert Pluim
0 siblings, 0 replies; 3+ messages in thread
From: Robert Pluim @ 2022-10-14 13:11 UTC (permalink / raw)
To: Vibhav Pant; +Cc: Po Lu, emacs-devel
>>>>> On Fri, 14 Oct 2022 18:28:39 +0530, Vibhav Pant <vibhavp@gmail.com> said:
Vibhav> On Fri, 2022-10-14 at 20:10 +0800, Po Lu wrote:
>> This is not how we write commit messages; it should be:
>>
>> * src/comp.c: Add declarations for creating
>> constructor/initializer expressions when supported.
>> (emit_coerce): Use a struct constructor expression to create a
>> Lisp_Object value instead of creating a new local variable.
>> (emit_limple_call_ref): Emit a single constructor expression for
>> initializing tmp_arr.
>>
>> Keep in mind that the commit message must also be filled to 64
>> columns.
Vibhav> Ah, knew something about it was off. Thanks :)
See also "** Generating ChangeLog entries" in CONTRIBUTE, it describes
Emacs facilities to help here.
Robert
--
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-14 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <166574864429.19305.16697125442242926452@vcs2.savannah.gnu.org>
[not found] ` <20221014115724.B04FCC1AB4A@vcs2.savannah.gnu.org>
2022-10-14 12:10 ` feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible Po Lu
2022-10-14 12:58 ` Vibhav Pant
2022-10-14 13:11 ` Robert Pluim
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).