From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible. Date: Fri, 14 Oct 2022 15:11:09 +0200 Message-ID: <875ygmzh1u.fsf@gmail.com> References: <166574864429.19305.16697125442242926452@vcs2.savannah.gnu.org> <20221014115724.B04FCC1AB4A@vcs2.savannah.gnu.org> <87a65y7git.fsf@yahoo.com> <4b63673d4a922066e9fd3a549ae6020cff4085e3.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38609"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel@gnu.org To: Vibhav Pant Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 14 15:13:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojKVF-0009ub-KX for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Oct 2022 15:13:29 +0200 Original-Received: from localhost ([::1]:45264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojKVE-0001QT-Kg for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Oct 2022 09:13:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojKT5-0007Vc-1A for emacs-devel@gnu.org; Fri, 14 Oct 2022 09:11:15 -0400 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:33440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojKT2-0003zf-JT for emacs-devel@gnu.org; Fri, 14 Oct 2022 09:11:14 -0400 Original-Received: by mail-wr1-x433.google.com with SMTP id a3so7582497wrt.0 for ; Fri, 14 Oct 2022 06:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=vK3+EZXSgzFAUxmVP6MD5Jg/Wr6HlSG9fgJuG/RQgaI=; b=MgdkMSs1tMbof0Qn27IqLjAVEkhaWUJrTX5tRHo5KiQtAkuYfDr8fB8ModcUJSoN8W bEXbLgdW8ObXoAFrl7ujJsvB3BrwKT47J+U0vah+zoDEW6/vXBkYFZYcCu60J4pzvonQ 8qYhxFYfQL9lBrKAVrD5gND7EIsL1Rn7UHW/QNrz2206k1NGqRZb/gIhocKRKNbwPF3V xAl1LE9Qy6aDeJWWaQePDDXLyxAqVQFOfva/0OBGn4IaxO1QQ+zEQRRvHE5y9TPHP/ef Oso3sWusUGRvXiEjSIeMVglyoE7K+d2pzymjWFje4r4lvrKDNDSwACwjbg+r8ZZAlg5z tYxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vK3+EZXSgzFAUxmVP6MD5Jg/Wr6HlSG9fgJuG/RQgaI=; b=EcmaiIJdEZpJV/AbEhhFwUgyF/tGo3IHAjbJ9uq/5e85T76ynFkNIYhs+YRzTr+jMa XLf2QjznCe48udZnHWGei8nXNRJPcd2FEqIIIRGYzp7TFZU6vAd9iJH/evEuZSlP3Obm 81c0KVeFkV/aklKkmPMR3YrtE1wMjrKe6nVrEjgpOJj7qo1d9HKDRp2ELwdHi59qPTWi tjz6/lHHGQZ7QBEeDxKZ8JNj/S6MOrVNbtMOu5eAPRkRvBwxXZw99juRCKPekhiwm0q0 pPejVdwTgmKtq38FG60iZS3Z3UEYQWzlywkF/ObAR9sjwq7heqzrQLSv3Vszu08s7ZpV 0bZw== X-Gm-Message-State: ACrzQf27qkXplaeI06D+2q7H86S7RDZuiUpcQApwO4SQeF5KCbgTWgiW odO64H5u1rAc12zPzMgz5yGo2uO51rY= X-Google-Smtp-Source: AMsMyM7mRXQ4fDtNg/RwrjiRc5ju4kLa5peVPgxzm3g7ZaMsB2/H+ejAAYiES69g1ku7NdEIpMoq4g== X-Received: by 2002:adf:d842:0:b0:22e:33e2:f379 with SMTP id k2-20020adfd842000000b0022e33e2f379mr3296128wrl.23.1665753070578; Fri, 14 Oct 2022 06:11:10 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id o5-20020a5d62c5000000b00228cbac7a25sm1914304wrv.64.2022.10.14.06.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 06:11:09 -0700 (PDT) In-Reply-To: <4b63673d4a922066e9fd3a549ae6020cff4085e3.camel@gmail.com> (Vibhav Pant's message of "Fri, 14 Oct 2022 18:28:39 +0530") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=rpluim@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297721 Archived-At: >>>>> On Fri, 14 Oct 2022 18:28:39 +0530, Vibhav Pant said: Vibhav> On Fri, 2022-10-14 at 20:10 +0800, Po Lu wrote: >> This is not how we write commit messages; it should be: >> >> * src/comp.c: Add declarations for creating >> constructor/initializer expressions when supported. >> (emit_coerce): Use a struct constructor expression to create a >> Lisp_Object value instead of creating a new local variable. >> (emit_limple_call_ref): Emit a single constructor expression for >> initializing tmp_arr. >> >> Keep in mind that the commit message must also be filled to 64 >> columns. Vibhav> Ah, knew something about it was off. Thanks :) See also "** Generating ChangeLog entries" in CONTRIBUTE, it describes Emacs facilities to help here. Robert --