From: Po Lu <luangruo@yahoo.com>
To: emacs-devel@gnu.org
Cc: Vibhav Pant <vibhavp@gmail.com>
Subject: Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.
Date: Fri, 14 Oct 2022 20:10:02 +0800 [thread overview]
Message-ID: <87a65y7git.fsf@yahoo.com> (raw)
In-Reply-To: <20221014115724.B04FCC1AB4A@vcs2.savannah.gnu.org> (Vibhav Pant's message of "Fri, 14 Oct 2022 07:57:24 -0400 (EDT)")
Vibhav Pant <vibhavp@gmail.com> writes:
> branch: feature/comp-use-ctors
> commit 1b48e8dde5bfee65c036fbfdc32b68c9093c2e06
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
> src/comp.c: Use constructor expressions when possible.
>
> * src/comp.c:
> - Add declarations for creating constructor/initializer expressions
> when supported.
> - (emit_coerce): Use a struct constructor expression to create a
> Lisp_Object value instead of creating a new local variable.
> - emit_limple_call_ref: Emit a single constructor expression for
> initializing tmp_arr.
This is not how we write commit messages; it should be:
* src/comp.c: Add declarations for creating
constructor/initializer expressions when supported.
(emit_coerce): Use a struct constructor expression to create a
Lisp_Object value instead of creating a new local variable.
(emit_limple_call_ref): Emit a single constructor expression for
initializing tmp_arr.
Keep in mind that the commit message must also be filled to 64 columns.
next parent reply other threads:[~2022-10-14 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166574864429.19305.16697125442242926452@vcs2.savannah.gnu.org>
[not found] ` <20221014115724.B04FCC1AB4A@vcs2.savannah.gnu.org>
2022-10-14 12:10 ` Po Lu [this message]
2022-10-14 12:58 ` feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible Vibhav Pant
2022-10-14 13:11 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a65y7git.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=emacs-devel@gnu.org \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).