From: Robert Pluim <rpluim@gmail.com>
To: Vibhav Pant <vibhavp@gmail.com>
Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org
Subject: Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.
Date: Fri, 14 Oct 2022 15:11:09 +0200 [thread overview]
Message-ID: <875ygmzh1u.fsf@gmail.com> (raw)
In-Reply-To: <4b63673d4a922066e9fd3a549ae6020cff4085e3.camel@gmail.com> (Vibhav Pant's message of "Fri, 14 Oct 2022 18:28:39 +0530")
>>>>> On Fri, 14 Oct 2022 18:28:39 +0530, Vibhav Pant <vibhavp@gmail.com> said:
Vibhav> On Fri, 2022-10-14 at 20:10 +0800, Po Lu wrote:
>> This is not how we write commit messages; it should be:
>>
>> * src/comp.c: Add declarations for creating
>> constructor/initializer expressions when supported.
>> (emit_coerce): Use a struct constructor expression to create a
>> Lisp_Object value instead of creating a new local variable.
>> (emit_limple_call_ref): Emit a single constructor expression for
>> initializing tmp_arr.
>>
>> Keep in mind that the commit message must also be filled to 64
>> columns.
Vibhav> Ah, knew something about it was off. Thanks :)
See also "** Generating ChangeLog entries" in CONTRIBUTE, it describes
Emacs facilities to help here.
Robert
--
prev parent reply other threads:[~2022-10-14 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166574864429.19305.16697125442242926452@vcs2.savannah.gnu.org>
[not found] ` <20221014115724.B04FCC1AB4A@vcs2.savannah.gnu.org>
2022-10-14 12:10 ` feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible Po Lu
2022-10-14 12:58 ` Vibhav Pant
2022-10-14 13:11 ` Robert Pluim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ygmzh1u.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).