From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads. Date: Mon, 28 Dec 2015 18:26:58 +0200 Message-ID: <83ege6fsj1.fsf@gnu.org> References: <87k2ph3mgx.fsf@gnu.org> <87io4lnkyz.fsf@gnu.org> <83mvtwoktg.fsf@gnu.org> <878u5gkakj.fsf@gnu.org> <83a8pwoesc.fsf@gnu.org> <87two3475d.fsf@gnu.org> <5665D6B9.4030309@cs.ucla.edu> <5665DAA1.2080208@cs.ucla.edu> <83k2o9t6t1.fsf@gnu.org> <56771D52.2070406@cs.ucla.edu> <83fuytp1au.fsf@gnu.org> <568073A4.3010604@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1451319982 1585 80.91.229.3 (28 Dec 2015 16:26:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 16:26:22 +0000 (UTC) Cc: p.stephani2@gmail.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 28 17:26:20 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDacl-00073y-17 for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 17:26:19 +0100 Original-Received: from localhost ([::1]:45020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDack-0004gu-DY for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 11:26:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDacg-0004fW-2g for emacs-devel@gnu.org; Mon, 28 Dec 2015 11:26:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDacc-0007fE-NC for emacs-devel@gnu.org; Mon, 28 Dec 2015 11:26:14 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDacc-0007eh-Fh; Mon, 28 Dec 2015 11:26:10 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3884 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aDacZ-0001KS-03; Mon, 28 Dec 2015 11:26:09 -0500 In-reply-to: <568073A4.3010604@cs.ucla.edu> (message from Paul Eggert on Sun, 27 Dec 2015 15:26:28 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197012 Archived-At: > Cc: emacs-devel@gnu.org > From: Paul Eggert > Date: Sun, 27 Dec 2015 15:26:28 -0800 > > * Document the changes in etc/NEWS and in the relevant part of the manual. > > * Use "deterministic-build", not "deterministic-dump", for the name. I didn't > understand the need for two variables here; we can add another one if needed. > > * Represent unknown values with nil, not with magic strings like "elided" or > "unknown". > > * Make emacs-build-time deterministic, too. > > * Adjust the output of emacs-version and similar functions to omit the build date. > > * Remove what appears to be an unnecessary initialization in 'main'. Fine with me in general, with the following comments: > --- a/doc/lispref/intro.texi > +++ b/doc/lispref/intro.texi > @@ -491,19 +491,6 @@ Version Info > giving a prefix argument makes @var{here} non-@code{nil}. > @end deffn > > -@defvar emacs-build-time > -The value of this variable indicates the time at which Emacs was > -built. It is a list of four integers, like the value of > -@code{current-time} (@pxref{Time of Day}). > - > -@example > -@group > -emacs-build-time > - @result{} (20614 63694 515336 438000) > -@end group > -@end example > -@end defvar Please let's nott remove this part, we are not removing the variable (and won't be any time soon). Let's just document that the value can be nil in a "deterministic build". > -;; I think this should be obsoleted/removed. It's just one more meaningless > -;; difference between different builds. It's usually not even an fqdn. > -(defconst emacs-build-system (system-name) > - "Name of the system on which Emacs was built.") > +(defconst emacs-build-system > + (if (not deterministic-build) (system-name)) > + "Name of the system on which Emacs was built, or nil if not available.") This causes an error in "M-x report-emacs-bug", so something should be done here or there. (I don't understand why you are so objected to keeping this a string, even though I specifically stated that I would like to keep it a string. Is it really worth another dispute?) Thanks.