* Re: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.
@ 2021-01-07 14:03 Eli Zaretskii
2021-01-07 17:50 ` Juri Linkov
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2021-01-07 14:03 UTC (permalink / raw)
To: Gabriel do Nascimento Ribeiro; +Cc: emacs-devel, Juri Linkov
> branch: master
> commit 7936c8a96060fa118220d4d874f740dc75e2fe47
> Author: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>
> Commit: Juri Linkov <juri@linkov.net>
>
> * lisp/mb-depth.el (minibuffer-depth-indicator): New face.
>
> (minibuffer-depth-setup): Use new face and add a single space between
> the depth indicator and the minibuffer prompt.
> https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00230.html
This change causes a byte-compilation warning:
In toplevel form:
mb-depth.el:38:1: Warning: defface for `minibuffer-depth-indicator' fails to
specify containing group
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.
2021-01-07 14:03 master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face Eli Zaretskii
@ 2021-01-07 17:50 ` Juri Linkov
2021-01-07 19:26 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Juri Linkov @ 2021-01-07 17:50 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Gabriel do Nascimento Ribeiro, emacs-devel
>> * lisp/mb-depth.el (minibuffer-depth-indicator): New face.
>>
>> (minibuffer-depth-setup): Use new face and add a single space between
>> the depth indicator and the minibuffer prompt.
>> https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00230.html
>
> This change causes a byte-compilation warning:
>
> In toplevel form:
> mb-depth.el:38:1: Warning: defface for `minibuffer-depth-indicator' fails to
> specify containing group
The question is what group to add. Drew proposed :group 'convenience'
and 'faces'. Gabriel proposed 'basic-faces'. But the problem is that
minibuffer-depth-indicate-mode already has the :group 'minibuffer'.
So it seems its face should be added to the same group.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.
2021-01-07 17:50 ` Juri Linkov
@ 2021-01-07 19:26 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2021-01-07 19:26 UTC (permalink / raw)
To: Juri Linkov; +Cc: gabriel376, emacs-devel
> From: Juri Linkov <juri@linkov.net>
> Cc: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>,
> emacs-devel@gnu.org
> Date: Thu, 07 Jan 2021 19:50:27 +0200
>
> > In toplevel form:
> > mb-depth.el:38:1: Warning: defface for `minibuffer-depth-indicator' fails to
> > specify containing group
>
> The question is what group to add. Drew proposed :group 'convenience'
> and 'faces'. Gabriel proposed 'basic-faces'. But the problem is that
> minibuffer-depth-indicate-mode already has the :group 'minibuffer'.
> So it seems its face should be added to the same group.
Any reason NOT to add it to the 'minibuffer' group?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-07 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 14:03 master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face Eli Zaretskii
2021-01-07 17:50 ` Juri Linkov
2021-01-07 19:26 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).