From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>,
emacs-devel@gnu.org
Subject: Re: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face.
Date: Thu, 07 Jan 2021 19:50:27 +0200 [thread overview]
Message-ID: <878s94slho.fsf@mail.linkov.net> (raw)
In-Reply-To: 83y2h4lu90.fsf@gnu.org
>> * lisp/mb-depth.el (minibuffer-depth-indicator): New face.
>>
>> (minibuffer-depth-setup): Use new face and add a single space between
>> the depth indicator and the minibuffer prompt.
>> https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00230.html
>
> This change causes a byte-compilation warning:
>
> In toplevel form:
> mb-depth.el:38:1: Warning: defface for `minibuffer-depth-indicator' fails to
> specify containing group
The question is what group to add. Drew proposed :group 'convenience'
and 'faces'. Gabriel proposed 'basic-faces'. But the problem is that
minibuffer-depth-indicate-mode already has the :group 'minibuffer'.
So it seems its face should be added to the same group.
next prev parent reply other threads:[~2021-01-07 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 14:03 master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face Eli Zaretskii
2021-01-07 17:50 ` Juri Linkov [this message]
2021-01-07 19:26 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s94slho.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gabriel376@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).