From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face. Date: Thu, 07 Jan 2021 19:50:27 +0200 Organization: LINKOV.NET Message-ID: <878s94slho.fsf@mail.linkov.net> References: <83y2h4lu90.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18358"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gabriel do Nascimento Ribeiro , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 07 18:56:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxZVu-0004au-4D for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 18:55:58 +0100 Original-Received: from localhost ([::1]:36268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxZVt-0003QP-5u for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 12:55:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxZUl-0001oG-BC for emacs-devel@gnu.org; Thu, 07 Jan 2021 12:54:47 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:35337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxZUj-0001Z6-6G; Thu, 07 Jan 2021 12:54:47 -0500 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id EE664100005; Thu, 7 Jan 2021 17:54:40 +0000 (UTC) Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262699 Archived-At: >> * lisp/mb-depth.el (minibuffer-depth-indicator): New face. >> >> (minibuffer-depth-setup): Use new face and add a single space between >> the depth indicator and the minibuffer prompt. >> https://lists.gnu.org/archive/html/emacs-devel/2020-12/msg00230.html > > This change causes a byte-compilation warning: > > In toplevel form: > mb-depth.el:38:1: Warning: defface for `minibuffer-depth-indicator' fails to > specify containing group The question is what group to add. Drew proposed :group 'convenience' and 'faces'. Gabriel proposed 'basic-faces'. But the problem is that minibuffer-depth-indicate-mode already has the :group 'minibuffer'. So it seems its face should be added to the same group.