From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 7936c8a: * lisp/mb-depth.el
 (minibuffer-depth-indicator): New face.
Date: Thu, 07 Jan 2021 21:26:40 +0200
Message-ID: <837doolf9r.fsf@gnu.org>
References: <83y2h4lu90.fsf@gnu.org> <878s94slho.fsf@mail.linkov.net>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="40451"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: gabriel376@hotmail.com, emacs-devel@gnu.org
To: Juri Linkov <juri@linkov.net>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 07 20:28:44 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kxaxg-000AQv-4m
	for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 20:28:44 +0100
Original-Received: from localhost ([::1]:60394 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kxaxf-0002eo-6o
	for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Jan 2021 14:28:43 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36894)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kxavl-0001qN-Tf
 for emacs-devel@gnu.org; Thu, 07 Jan 2021 14:26:45 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34762)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kxavk-0000eg-CC; Thu, 07 Jan 2021 14:26:44 -0500
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2574
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kxavg-0004e6-Ub; Thu, 07 Jan 2021 14:26:41 -0500
In-Reply-To: <878s94slho.fsf@mail.linkov.net> (message from Juri Linkov on
 Thu, 07 Jan 2021 19:50:27 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:262703
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/262703>

> From: Juri Linkov <juri@linkov.net>
> Cc: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>,
>   emacs-devel@gnu.org
> Date: Thu, 07 Jan 2021 19:50:27 +0200
> 
> >   In toplevel form:
> >   mb-depth.el:38:1: Warning: defface for `minibuffer-depth-indicator' fails to
> >       specify containing group
> 
> The question is what group to add.  Drew proposed :group 'convenience'
> and 'faces'.  Gabriel proposed 'basic-faces'.  But the problem is that
> minibuffer-depth-indicate-mode already has the :group 'minibuffer'.
> So it seems its face should be added to the same group.

Any reason NOT to add it to the 'minibuffer' group?