From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads. Date: Wed, 23 Dec 2015 13:09:21 -0800 Organization: UCLA Computer Science Department Message-ID: <567B0D81.2000106@cs.ucla.edu> References: <87k2ph3mgx.fsf@gnu.org> <87io4lnkyz.fsf@gnu.org> <83mvtwoktg.fsf@gnu.org> <878u5gkakj.fsf@gnu.org> <83a8pwoesc.fsf@gnu.org> <87two3475d.fsf@gnu.org> <5665D6B9.4030309@cs.ucla.edu> <5665DAA1.2080208@cs.ucla.edu> <83k2o9t6t1.fsf@gnu.org> <56771D52.2070406@cs.ucla.edu> <83fuytp1au.fsf@gnu.org> <83d1txozu9.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1450904995 17830 80.91.229.3 (23 Dec 2015 21:09:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Dec 2015 21:09:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Philipp Stephani , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 23 22:09:45 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aBqfI-0007v5-5f for ged-emacs-devel@m.gmane.org; Wed, 23 Dec 2015 22:09:44 +0100 Original-Received: from localhost ([::1]:57904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBqfH-0008PE-8P for ged-emacs-devel@m.gmane.org; Wed, 23 Dec 2015 16:09:43 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBqf2-0008Oq-Ih for emacs-devel@gnu.org; Wed, 23 Dec 2015 16:09:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aBqf1-0004HG-MQ for emacs-devel@gnu.org; Wed, 23 Dec 2015 16:09:28 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aBqex-0004E0-Cf; Wed, 23 Dec 2015 16:09:23 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 182EB160D1A; Wed, 23 Dec 2015 13:09:22 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 2s4byru2N0FK; Wed, 23 Dec 2015 13:09:21 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 620CE160D24; Wed, 23 Dec 2015 13:09:21 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3RK0ZxsLc1xB; Wed, 23 Dec 2015 13:09:21 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 40D9416057C; Wed, 23 Dec 2015 13:09:21 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:196737 Archived-At: Philipp Stephani wrote: > I thought that too, but on second thought it seems rather difficult: the > variable should be set to nil by default in an initialized Emacs (and > probably also in temacs), yet we need a way to set it to t based on the > configuration option. Doesn't your proposed patch already set deterministic-dump to t based on the configuration option? I don't see the difficulty. > + (if deterministic-dump "unknown" (system-name)) How about changing this to: (when (not deterministic-dump) (system-name)) and document that the value is nil when unavailable? That should be cleaner than the confusion if a system name actually happens to be "unknown". Similarly, init_system_name should leave Vsystem_name alone when DETERMINISTIC_DUMP. > +#ifdef DETERMINISTIC_DUMP Please change this to "if (DETERMINISTIC_DUMP)", and similarly for other uses, and arrange for DETERMINISTIC_DUMP to be a constant false or true. Nowadays we should prefer macros to constants only when they're really necessary, which isn't the case here.