unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Nick Roberts <nickrob@snap.net.nz>
Cc: eliz@gnu.org, emacs-devel@gnu.org
Subject: Re: Overlay arrow in *compilation* and *grep* buffers
Date: Sat, 14 May 2005 01:02:02 +1200	[thread overview]
Message-ID: <17028.42314.992815.2073@farnswood.snap.net.nz> (raw)
In-Reply-To: <87is1nlnt1.fsf@jurta.org>

 > Even on text terminals users might prefer not to scroll the window.
 > Since overlay arrows are problematic on text terminals, there should
 > be an alternative method of highlighting.  I propose to add one of the
 > methods of next-error highlighting for compilation messages, i.e. a
 > persistent overlay fontified in a special face.
 > 
 > The new option compilation-current-message-highlight will support
 > three values: `arrow', t for highlighting the whole current message
 > line, and nil to turn all indications off.
 > 
 > The default value can be selected based on the following conditions:
 > 
 > 1. When left-fringe is available (tested with a condition like you proposed),
 >    use an arrow.
 > 2. Otherwise, if compilation-context-lines is nil, highlight the
 >    current line in a special face with the persistent overlay.
 > 3. If compilation-context-lines is not nil, don't highlight the current
 >    message since the current message is indicated by its location
 >    at the top of the window (by default).
 > 
 > There is a brief list of changes in the patch below:
 > 
 > 1. New defcustom compilation-current-message-highlight.
This value needs to be recomputed at compile time.

 > 2. compilation-context-lines moved up before compilation-context-lines.
                                  before compilation-current-message-highlight?

 > 3. compilation-highlight-overlay renamed to next-error-highlight-overlay,
 >    because this overlay is actually used for highlighting source lines
 >    visited by `next-error'.
 > 4. compilation-highlight-overlay is used for highlighting lines
 >    in the compilation buffer.
 > 6. The value `fringe-arrow' renamed to more general name `arrow'.

Yes, it looks good. The default behaviour matches what was agreed in an earlier
thread.

On a related note, I think that the default value for next-error-highlight
should be nil, as the cursor already points to the source line of interest.

Nick

  parent reply	other threads:[~2005-05-13 13:02 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-24 10:45 Overlay arrow in *compilation* and *grep* buffers Eli Zaretskii
2005-04-24 18:42 ` Kim F. Storm
2005-04-24 20:04   ` Eli Zaretskii
2005-04-27 13:10     ` Kim F. Storm
2005-04-27 14:39       ` Eli Zaretskii
2005-04-28 11:01       ` Richard Stallman
2005-04-28 19:51         ` Eli Zaretskii
2005-04-28 20:54           ` Nick Roberts
2005-04-29  7:08             ` Eli Zaretskii
2005-04-29  8:52               ` Nick Roberts
2005-05-09 20:55                 ` Juri Linkov
2005-05-10  6:40                   ` David Kastrup
2005-05-12 11:38                   ` Nick Roberts
2005-05-13  1:34                     ` Richard Stallman
2005-05-13  5:03                     ` Juri Linkov
2005-05-13  6:08                       ` Eli Zaretskii
2005-05-13  7:18                         ` Nick Roberts
2005-05-13 13:28                           ` Eli Zaretskii
2005-05-14  0:26                             ` Richard Stallman
2005-05-14  7:17                               ` Eli Zaretskii
2005-05-14 22:20                                 ` Kim F. Storm
2005-05-15 15:58                                   ` Richard Stallman
2005-05-13 13:02                       ` Nick Roberts [this message]
2005-05-14  0:25                         ` Richard Stallman
2005-05-15  2:44                           ` Nick Roberts
2005-05-15  4:12                             ` Eli Zaretskii
2005-05-15  4:21                             ` Eli Zaretskii
2005-05-15 22:39                             ` Richard Stallman
2005-05-16  1:20                               ` Nick Roberts
2005-05-16 19:28                                 ` Richard Stallman
2005-05-16 19:28                                 ` Richard Stallman
2005-05-16 22:16                                   ` Nick Roberts
2005-05-17 13:23                                     ` Richard Stallman
2005-04-29 10:49         ` Nick Roberts
2005-05-07 16:20         ` Eli Zaretskii
2005-05-07 21:10           ` Kim F. Storm
2005-05-08  0:41             ` Nick Roberts
2005-05-08  4:21               ` Eli Zaretskii
2005-05-08  5:49                 ` Nick Roberts
2005-05-08 16:12                 ` Richard Stallman
2005-05-08 19:37                   ` Eli Zaretskii
2005-04-25 16:05 ` Richard Stallman
2005-04-25 16:46   ` Eli Zaretskii
2005-04-26 14:33     ` Richard Stallman
2005-04-28 11:34 ` Nick Roberts
2005-04-28 19:50   ` Eli Zaretskii
2005-04-28 21:16     ` Nick Roberts
2005-04-29 10:15   ` Richard Stallman
2005-04-29 12:19     ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17028.42314.992815.2073@farnswood.snap.net.nz \
    --to=nickrob@snap.net.nz \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).