From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: Overlay arrow in *compilation* and *grep* buffers Date: Sat, 14 May 2005 01:02:02 +1200 Message-ID: <17028.42314.992815.2073@farnswood.snap.net.nz> References: <01c548ba$Blat.v2.4$e4827900@zahav.net.il> <01c54909$Blat.v2.4$070f3e60@zahav.net.il> <01c54c2b$Blat.v2.4$e15e8560@zahav.net.il> <17009.19855.763603.487800@farnswood.snap.net.nz> <01c54c8a$Blat.v2.4$6afa17e0@zahav.net.il> <17009.62951.957607.360268@farnswood.snap.net.nz> <87oebkw22l.fsf@jurta.org> <17027.16429.215672.493633@farnswood.snap.net.nz> <87is1nlnt1.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1115988998 11495 80.91.229.2 (13 May 2005 12:56:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 13 May 2005 12:56:38 +0000 (UTC) Cc: eliz@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 13 14:56:30 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DWZi9-00057G-AQ for ged-emacs-devel@m.gmane.org; Fri, 13 May 2005 14:56:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DWZrI-0006uz-7i for ged-emacs-devel@m.gmane.org; Fri, 13 May 2005 09:05:40 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DWZqg-0006oB-G6 for emacs-devel@gnu.org; Fri, 13 May 2005 09:05:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DWZqb-0006k9-A8 for emacs-devel@gnu.org; Fri, 13 May 2005 09:04:57 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DWZqb-0006jK-1s for emacs-devel@gnu.org; Fri, 13 May 2005 09:04:57 -0400 Original-Received: from [202.37.101.8] (helo=viper.snap.net.nz) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DWZub-0005Sa-28; Fri, 13 May 2005 09:09:05 -0400 Original-Received: from farnswood.snap.net.nz (p227-tnt1.snap.net.nz [202.124.110.227]) by viper.snap.net.nz (Postfix) with ESMTP id 7FB745341B2; Sat, 14 May 2005 01:01:53 +1200 (NZST) Original-Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 6A54762ABC; Fri, 13 May 2005 14:02:04 +0100 (BST) Original-To: Juri Linkov In-Reply-To: <87is1nlnt1.fsf@jurta.org> X-Mailer: VM 7.19 under Emacs 22.0.50.44 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:37075 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:37075 > Even on text terminals users might prefer not to scroll the window. > Since overlay arrows are problematic on text terminals, there should > be an alternative method of highlighting. I propose to add one of the > methods of next-error highlighting for compilation messages, i.e. a > persistent overlay fontified in a special face. > > The new option compilation-current-message-highlight will support > three values: `arrow', t for highlighting the whole current message > line, and nil to turn all indications off. > > The default value can be selected based on the following conditions: > > 1. When left-fringe is available (tested with a condition like you proposed), > use an arrow. > 2. Otherwise, if compilation-context-lines is nil, highlight the > current line in a special face with the persistent overlay. > 3. If compilation-context-lines is not nil, don't highlight the current > message since the current message is indicated by its location > at the top of the window (by default). > > There is a brief list of changes in the patch below: > > 1. New defcustom compilation-current-message-highlight. This value needs to be recomputed at compile time. > 2. compilation-context-lines moved up before compilation-context-lines. before compilation-current-message-highlight? > 3. compilation-highlight-overlay renamed to next-error-highlight-overlay, > because this overlay is actually used for highlighting source lines > visited by `next-error'. > 4. compilation-highlight-overlay is used for highlighting lines > in the compilation buffer. > 6. The value `fringe-arrow' renamed to more general name `arrow'. Yes, it looks good. The default behaviour matches what was agreed in an earlier thread. On a related note, I think that the default value for next-error-highlight should be nil, as the cursor already points to the source line of interest. Nick