* bug#43892: [PATCH] Native-comp: fix compilation warnings
@ 2020-10-09 21:44 Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-09 22:35 ` bug#43892: [PATCH] Native comp: " Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-09 21:44 UTC (permalink / raw)
To: 43892
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
This is for the native-comp branch.
I also attached my FSF papers from when I contributed to an external Emacs package. Not sure if I need separate forms right now.
--
Sent with https://mailfence.com
Secure and private email
[-- Attachment #2: File Attachment: leung.tar.gz --]
[-- Type: application/x-gzip, Size: 148289 bytes --]
[-- Attachment #3: File Attachment: 0001-Fix-some-compilation-warnings.patch --]
[-- Type: text/x-diff, Size: 2871 bytes --]
From f291c25eac1785e2a5d4ace381a44e0ebef5f7db Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Fri, 9 Oct 2020 14:35:26 -0700
Subject: [PATCH] ; Fix some compilation warnings
---
lisp/emacs-lisp/advice.el | 2 ++
lisp/emacs-lisp/find-func.el | 2 ++
lisp/emacs-lisp/nadvice.el | 2 ++
lisp/files.el | 2 ++
lisp/help.el | 2 ++
5 files changed, 10 insertions(+)
diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index fb67de3a02..509e255191 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -2052,6 +2052,8 @@ ad-remove-advice
function class name)))
(error "ad-remove-advice: `%s' is not advised" function)))
+(declare-function comp-subr-trampoline-install "comp")
+
;;;###autoload
(defun ad-add-advice (function advice class position)
"Add a piece of ADVICE to FUNCTION's list of advices in CLASS.
diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
index 9e4d8cf1aa..4417082971 100644
--- a/lisp/emacs-lisp/find-func.el
+++ b/lisp/emacs-lisp/find-func.el
@@ -178,6 +178,8 @@ find-library--load-name
(setq name rel))))
(unless (equal name library) name)))
+(defvar comp-eln-to-el-h)
+
(defun find-library-name (library)
"Return the absolute file name of the Emacs Lisp source of LIBRARY.
LIBRARY should be a string (the name of the library)."
diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index 0396132585..4a55dbfcd5 100644
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -316,6 +316,8 @@ add-function
`(advice--add-function ,where (gv-ref ,(advice--normalize-place place))
,function ,props))
+(declare-function comp-subr-trampoline-install "comp")
+
;;;###autoload
(defun advice--add-function (where ref function props)
(when (and (boundp 'comp-ctxt)
diff --git a/lisp/files.el b/lisp/files.el
index 833a188b03..1d330ce87b 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -900,6 +900,8 @@ load-file
(read-file-name "Load file: " nil nil 'lambda))))
(load (expand-file-name file) nil nil t))
+(defvar comp-eln-to-el-h)
+
(defun locate-file (filename path &optional suffixes predicate)
"Search for FILENAME through PATH.
If found, return the absolute file name of FILENAME; otherwise
diff --git a/lisp/help.el b/lisp/help.el
index 4d0c4d5d98..f51f7f19c4 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -1320,6 +1320,8 @@ help-add-fundoc-usage
(error "Unrecognized usage format"))
(help--make-usage-docstring 'fn arglist)))))
+(declare-function subr-native-lambda-list "data.c")
+
(defun help-function-arglist (def &optional preserve-names)
"Return a formal argument list for the function DEF.
If PRESERVE-NAMES is non-nil, return a formal arglist that uses
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#43892: [PATCH] Native comp: fix compilation warnings
2020-10-09 21:44 bug#43892: [PATCH] Native-comp: fix compilation warnings Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-10-09 22:35 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-10 1:19 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-09 22:35 UTC (permalink / raw)
To: 43892
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
I found another warning, so please look at this patch instead, which supersedes the other one I sent.
--
Sent with https://mailfence.com
Secure and private email
[-- Attachment #2: File Attachment: 0001-Fix-some-compilation-warnings.patch --]
[-- Type: text/x-diff, Size: 3382 bytes --]
From f4de89bc3a2ebdeeb32586c283c87a3266ec8e0d Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Fri, 9 Oct 2020 14:35:26 -0700
Subject: [PATCH] ; Fix some compilation warnings
---
lisp/emacs-lisp/advice.el | 2 ++
lisp/emacs-lisp/comp.el | 2 ++
lisp/emacs-lisp/find-func.el | 2 ++
lisp/emacs-lisp/nadvice.el | 2 ++
lisp/files.el | 2 ++
lisp/help.el | 2 ++
6 files changed, 12 insertions(+)
diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index fb67de3a02..509e255191 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -2052,6 +2052,8 @@ ad-remove-advice
function class name)))
(error "ad-remove-advice: `%s' is not advised" function)))
+(declare-function comp-subr-trampoline-install "comp")
+
;;;###autoload
(defun ad-add-advice (function advice class position)
"Add a piece of ADVICE to FUNCTION's list of advices in CLASS.
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 763d44a23e..4cc0145e3b 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -2613,6 +2613,8 @@ comp-tampoline-compile
finally (error "Can't find a writable directory in \
`comp-eln-load-path'")))))
+(defvar comp-installed-trampolines-h)
+
;;;###autoload
(defun comp-subr-trampoline-install (subr-name)
"Make SUBR-NAME effectively advice-able when called from native code."
diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
index 9e4d8cf1aa..4417082971 100644
--- a/lisp/emacs-lisp/find-func.el
+++ b/lisp/emacs-lisp/find-func.el
@@ -178,6 +178,8 @@ find-library--load-name
(setq name rel))))
(unless (equal name library) name)))
+(defvar comp-eln-to-el-h)
+
(defun find-library-name (library)
"Return the absolute file name of the Emacs Lisp source of LIBRARY.
LIBRARY should be a string (the name of the library)."
diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index 0396132585..4a55dbfcd5 100644
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -316,6 +316,8 @@ add-function
`(advice--add-function ,where (gv-ref ,(advice--normalize-place place))
,function ,props))
+(declare-function comp-subr-trampoline-install "comp")
+
;;;###autoload
(defun advice--add-function (where ref function props)
(when (and (boundp 'comp-ctxt)
diff --git a/lisp/files.el b/lisp/files.el
index 833a188b03..1d330ce87b 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -900,6 +900,8 @@ load-file
(read-file-name "Load file: " nil nil 'lambda))))
(load (expand-file-name file) nil nil t))
+(defvar comp-eln-to-el-h)
+
(defun locate-file (filename path &optional suffixes predicate)
"Search for FILENAME through PATH.
If found, return the absolute file name of FILENAME; otherwise
diff --git a/lisp/help.el b/lisp/help.el
index 4d0c4d5d98..f51f7f19c4 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -1320,6 +1320,8 @@ help-add-fundoc-usage
(error "Unrecognized usage format"))
(help--make-usage-docstring 'fn arglist)))))
+(declare-function subr-native-lambda-list "data.c")
+
(defun help-function-arglist (def &optional preserve-names)
"Return a formal argument list for the function DEF.
If PRESERVE-NAMES is non-nil, return a formal arglist that uses
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#43892: [PATCH] Native comp: fix compilation warnings
2020-10-09 22:35 ` bug#43892: [PATCH] Native comp: " Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-10-10 1:19 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 7:05 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-10 1:19 UTC (permalink / raw)
To: 43892
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
Actually, I'm not sure my most recent patch is necessary. Please review this instead, which is the first one again.
> ----------------------------------------
> From: Brian Leung <leungbk@mailfence.com>
> Sent: Sat Oct 10 00:35:58 CEST 2020
> To: <43892@debbugs.gnu.org>
> Subject: [PATCH] Native comp: fix compilation warnings
>
>
> I found another warning, so please look at this patch instead, which supersedes the other one I sent.
>
> --
> Sent with https://mailfence.com
> Secure and private email
--
Sent with https://mailfence.com
Secure and private email
[-- Attachment #2: File Attachment: 0001-Fix-some-compilation-warnings.patch --]
[-- Type: text/x-diff, Size: 2871 bytes --]
From a308ae018f5f586c1ebf1e01a16ba4647717e518 Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Fri, 9 Oct 2020 14:35:26 -0700
Subject: [PATCH] ; Fix some compilation warnings
---
lisp/emacs-lisp/advice.el | 2 ++
lisp/emacs-lisp/find-func.el | 2 ++
lisp/emacs-lisp/nadvice.el | 2 ++
lisp/files.el | 2 ++
lisp/help.el | 2 ++
5 files changed, 10 insertions(+)
diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index fb67de3a02..509e255191 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -2052,6 +2052,8 @@ ad-remove-advice
function class name)))
(error "ad-remove-advice: `%s' is not advised" function)))
+(declare-function comp-subr-trampoline-install "comp")
+
;;;###autoload
(defun ad-add-advice (function advice class position)
"Add a piece of ADVICE to FUNCTION's list of advices in CLASS.
diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
index 9e4d8cf1aa..4417082971 100644
--- a/lisp/emacs-lisp/find-func.el
+++ b/lisp/emacs-lisp/find-func.el
@@ -178,6 +178,8 @@ find-library--load-name
(setq name rel))))
(unless (equal name library) name)))
+(defvar comp-eln-to-el-h)
+
(defun find-library-name (library)
"Return the absolute file name of the Emacs Lisp source of LIBRARY.
LIBRARY should be a string (the name of the library)."
diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index 0396132585..4a55dbfcd5 100644
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -316,6 +316,8 @@ add-function
`(advice--add-function ,where (gv-ref ,(advice--normalize-place place))
,function ,props))
+(declare-function comp-subr-trampoline-install "comp")
+
;;;###autoload
(defun advice--add-function (where ref function props)
(when (and (boundp 'comp-ctxt)
diff --git a/lisp/files.el b/lisp/files.el
index 833a188b03..1d330ce87b 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -900,6 +900,8 @@ load-file
(read-file-name "Load file: " nil nil 'lambda))))
(load (expand-file-name file) nil nil t))
+(defvar comp-eln-to-el-h)
+
(defun locate-file (filename path &optional suffixes predicate)
"Search for FILENAME through PATH.
If found, return the absolute file name of FILENAME; otherwise
diff --git a/lisp/help.el b/lisp/help.el
index 4d0c4d5d98..f51f7f19c4 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -1320,6 +1320,8 @@ help-add-fundoc-usage
(error "Unrecognized usage format"))
(help--make-usage-docstring 'fn arglist)))))
+(declare-function subr-native-lambda-list "data.c")
+
(defun help-function-arglist (def &optional preserve-names)
"Return a formal argument list for the function DEF.
If PRESERVE-NAMES is non-nil, return a formal arglist that uses
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#43892: [PATCH] Native comp: fix compilation warnings
2020-10-10 1:19 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-10-12 7:05 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 17:40 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-12 7:05 UTC (permalink / raw)
To: 43892; +Cc: leungbk
Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@gnu.org> writes:
> Actually, I'm not sure my most recent patch is necessary. Please review this instead, which is the first one again.
>
Hi Brian,
could you double check the patch applies and re-send it with a ChangeLog
entry (see ** Commit messages in the CONTRIBUTE file)?
Thanks
Andrea
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#43892: [PATCH] Native comp: fix compilation warnings
2020-10-12 7:05 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-10-12 17:40 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 19:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-12 17:40 UTC (permalink / raw)
To: akrl, 43892
[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]
Hi Andrea,
I have rebased the patch and attached. I looked at the CONTRIBUTE file, which says that minor commits with "; " in front do not need Changelog entries. I feel like this patch is pretty minor, so I'm not sure if it warrants a Changelog entry. Let me know what you think.
Thanks,
Brian
> ----------------------------------------
> From: Andrea Corallo <akrl@sdf.org>
> Sent: Mon Oct 12 09:05:31 CEST 2020
> To: Brian Leung via "Bug reports for GNU Emacs the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> Cc: <43892@debbugs.gnu.org>, Brian Leung <leungbk@mailfence.com>
> Subject: Re: bug#43892: [PATCH] Native comp: fix compilation warnings
>
>
> Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs@gnu.org> writes:
>
> > Actually, I'm not sure my most recent patch is necessary. Please review this instead, which is the first one again.
> >
>
> Hi Brian,
>
> could you double check the patch applies and re-send it with a ChangeLog
> entry (see ** Commit messages in the CONTRIBUTE file)?
>
> Thanks
>
> Andrea
--
Sent with https://mailfence.com
Secure and private email
[-- Attachment #2: File Attachment: 0001-Fix-some-compilation-warnings.patch --]
[-- Type: text/x-diff, Size: 3194 bytes --]
From 004abde9b6a20677d6eafefc50834b257a44edf2 Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Fri, 9 Oct 2020 14:35:26 -0700
Subject: [PATCH] ; Fix some compilation warnings
lisp/emacs-lisp/advice.el: Declare comp-subr-trampoline-install function.
lisp/emacs-lisp/find-func.el: Declare comp-eln-to-el-h variable.
lisp/emacs-lisp/nadvice.el: Declare comp-subr-trampoline-install function.
lisp/files.el: Declare comp-eln-to-el-h variable.
lisp/help.el: Declare subr-native-lambda-list function.
---
lisp/emacs-lisp/advice.el | 2 ++
lisp/emacs-lisp/find-func.el | 2 ++
lisp/emacs-lisp/nadvice.el | 2 ++
lisp/files.el | 2 ++
lisp/help.el | 2 ++
5 files changed, 10 insertions(+)
diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index fb67de3a02..509e255191 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -2052,6 +2052,8 @@ ad-remove-advice
function class name)))
(error "ad-remove-advice: `%s' is not advised" function)))
+(declare-function comp-subr-trampoline-install "comp")
+
;;;###autoload
(defun ad-add-advice (function advice class position)
"Add a piece of ADVICE to FUNCTION's list of advices in CLASS.
diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
index 9e4d8cf1aa..4417082971 100644
--- a/lisp/emacs-lisp/find-func.el
+++ b/lisp/emacs-lisp/find-func.el
@@ -178,6 +178,8 @@ find-library--load-name
(setq name rel))))
(unless (equal name library) name)))
+(defvar comp-eln-to-el-h)
+
(defun find-library-name (library)
"Return the absolute file name of the Emacs Lisp source of LIBRARY.
LIBRARY should be a string (the name of the library)."
diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index 8b60c08440..e68c135608 100644
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -316,6 +316,8 @@ add-function
`(advice--add-function ,where (gv-ref ,(advice--normalize-place place))
,function ,props))
+(declare-function comp-subr-trampoline-install "comp")
+
;;;###autoload
(defun advice--add-function (where ref function props)
(when (and (featurep 'nativecomp)
diff --git a/lisp/files.el b/lisp/files.el
index 833a188b03..1d330ce87b 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -900,6 +900,8 @@ load-file
(read-file-name "Load file: " nil nil 'lambda))))
(load (expand-file-name file) nil nil t))
+(defvar comp-eln-to-el-h)
+
(defun locate-file (filename path &optional suffixes predicate)
"Search for FILENAME through PATH.
If found, return the absolute file name of FILENAME; otherwise
diff --git a/lisp/help.el b/lisp/help.el
index c166b63a56..1a3fd35e44 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -1320,6 +1320,8 @@ help-add-fundoc-usage
(error "Unrecognized usage format"))
(help--make-usage-docstring 'fn arglist)))))
+(declare-function subr-native-lambda-list "data.c")
+
(defun help-function-arglist (def &optional preserve-names)
"Return a formal argument list for the function DEF.
If PRESERVE-NAMES is non-nil, return a formal arglist that uses
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#43892: [PATCH] Native comp: fix compilation warnings
2020-10-12 17:40 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2020-10-12 19:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 6+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2020-10-12 19:28 UTC (permalink / raw)
To: 43892; +Cc: 43892-done, Brian Leung
Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@gnu.org> writes:
> Hi Andrea,
>
> I have rebased the patch and attached. I looked at the CONTRIBUTE
> file, which says that minor commits with "; " in front do not need
> Changelog entries. I feel like this patch is pretty minor, so I'm not
> sure if it warrants a Changelog entry. Let me know what you think.
Hi Brian,
I don't think this has to be considered minor. I've just improved a bit
commit message and Changelog entry and pushed it as 237fd33aef.
Thanks for the patch, closing.
Andrea
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-12 19:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09 21:44 bug#43892: [PATCH] Native-comp: fix compilation warnings Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-09 22:35 ` bug#43892: [PATCH] Native comp: " Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-10 1:19 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 7:05 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 17:40 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 19:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).