From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 43892@debbugs.gnu.org
Cc: 43892-done@debbugs.gnu.org, Brian Leung <leungbk@mailfence.com>
Subject: bug#43892: [PATCH] Native comp: fix compilation warnings
Date: Mon, 12 Oct 2020 19:28:31 +0000 [thread overview]
Message-ID: <xjfpn5nnt0g.fsf@sdf.org> (raw)
In-Reply-To: <1710269652.302891.1602524422518@ichabod.co-bxl> (Brian Leung via's message of "Mon, 12 Oct 2020 19:40:22 +0200 (CEST)")
Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@gnu.org> writes:
> Hi Andrea,
>
> I have rebased the patch and attached. I looked at the CONTRIBUTE
> file, which says that minor commits with "; " in front do not need
> Changelog entries. I feel like this patch is pretty minor, so I'm not
> sure if it warrants a Changelog entry. Let me know what you think.
Hi Brian,
I don't think this has to be considered minor. I've just improved a bit
commit message and Changelog entry and pushed it as 237fd33aef.
Thanks for the patch, closing.
Andrea
prev parent reply other threads:[~2020-10-12 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 21:44 bug#43892: [PATCH] Native-comp: fix compilation warnings Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-09 22:35 ` bug#43892: [PATCH] Native comp: " Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-10 1:19 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 7:05 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 17:40 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 19:28 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfpn5nnt0g.fsf@sdf.org \
--to=bug-gnu-emacs@gnu.org \
--cc=43892-done@debbugs.gnu.org \
--cc=43892@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=leungbk@mailfence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).