From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43892: [PATCH] Native comp: fix compilation warnings Date: Sat, 10 Oct 2020 03:19:58 +0200 (CEST) Message-ID: <1749446071.142449.1602292798440@ichabod.co-bxl> References: <306152990.137422.1602282958454@ichabod.co-bxl> Reply-To: Brian Leung , Brian Leung Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_142409_213898088.1602292736929" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32454"; mail-complaints-to="usenet@ciao.gmane.io" To: 43892@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 10 03:21:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kR3ZO-0008Iu-2z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Oct 2020 03:21:10 +0200 Original-Received: from localhost ([::1]:58012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kR3ZM-0004TI-Ic for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Oct 2020 21:21:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kR3ZG-0004T9-B1 for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2020 21:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kR3ZG-0008FT-1j for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2020 21:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kR3ZF-0000xX-Tn for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2020 21:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Brian Leung Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Oct 2020 01:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43892 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43892-submit@debbugs.gnu.org id=B43892.16022928133606 (code B ref 43892); Sat, 10 Oct 2020 01:21:01 +0000 Original-Received: (at 43892) by debbugs.gnu.org; 10 Oct 2020 01:20:13 +0000 Original-Received: from localhost ([127.0.0.1]:36689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kR3YS-0000w5-OY for submit@debbugs.gnu.org; Fri, 09 Oct 2020 21:20:13 -0400 Original-Received: from mailout-l3b-97.contactoffice.com ([212.3.242.97]:42738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kR3YO-0000vT-Eg for 43892@debbugs.gnu.org; Fri, 09 Oct 2020 21:20:11 -0400 Original-Received: from ichabod.co-bxl (ichabod.co-bxl [10.2.0.36]) by mailout-l3b-97.contactoffice.com (Postfix) with ESMTP id 961EF8E0 for <43892@debbugs.gnu.org>; Sat, 10 Oct 2020 03:20:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailfence.com; s=20160819-nLV10XS2; t=1602292801; bh=Qp5UHTLip9r3qPoOOYPFSWbRiQhr+9Ew2zLixwl/94g=; h=Date:From:Reply-To:To:In-Reply-To:References:Subject:From; b=VGZqnLgHeJKMGkvKa2VTrgLKkea+dSFfBa+HR+CdRId/KG6q14bILPzV7eVTi4zxb guasVKVJTbIPmd/jqj9Hlaa6xQzmyDNmQ3Ye2szXnqMzXORAE3uM1tp1el//UTVD2T 9HQT+8dIt+xjHDsr3GR63L8LsgNJO/mvOYKbtphPphDHwvDKK1httJ0UI2JeDevN57 GDQ0WcDMrsh3wo00VfYrFZM5k5Tlo6Y81PuwzF2Z2FNbVYUCVyAXd++exPvHMfz1wL sU5+rE3Cb7H5Rn9+g8LpDvqLdAuHBOce4RnuO69UUurJ8I5N7AolxqjQKHVe8cqZNY ZPWZvH/79bHNA== In-Reply-To: <306152990.137422.1602282958454@ichabod.co-bxl> X-Priority: 3 X-Mailer: ContactOffice Mail X-ContactOffice-Account: com:225491745 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190189 Archived-At: ------=_Part_142409_213898088.1602292736929 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Actually, I'm not sure my most recent patch is necessary. Please review thi= s instead, which is the first one again. > ---------------------------------------- > From: Brian Leung > Sent: Sat Oct 10 00:35:58 CEST 2020 > To: <43892@debbugs.gnu.org> > Subject: [PATCH] Native comp: fix compilation warnings >=20 >=20 > I found another warning, so please look at this patch instead, which supe= rsedes the other one I sent. >=20 > --=C2=A0 > Sent with https://mailfence.com > Secure and private email --=C2=A0 Sent with https://mailfence.com Secure and private email ------=_Part_142409_213898088.1602292736929 Content-Type: text/x-diff; charset=us-ascii; name=0001-Fix-some-compilation-warnings.patch Content-Transfer-Encoding: 7bit Content-Description: File Attachment: 0001-Fix-some-compilation-warnings.patch Content-Disposition: attachment; filename=0001-Fix-some-compilation-warnings.patch >From a308ae018f5f586c1ebf1e01a16ba4647717e518 Mon Sep 17 00:00:00 2001 From: Brian Leung Date: Fri, 9 Oct 2020 14:35:26 -0700 Subject: [PATCH] ; Fix some compilation warnings --- lisp/emacs-lisp/advice.el | 2 ++ lisp/emacs-lisp/find-func.el | 2 ++ lisp/emacs-lisp/nadvice.el | 2 ++ lisp/files.el | 2 ++ lisp/help.el | 2 ++ 5 files changed, 10 insertions(+) diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el index fb67de3a02..509e255191 100644 --- a/lisp/emacs-lisp/advice.el +++ b/lisp/emacs-lisp/advice.el @@ -2052,6 +2052,8 @@ ad-remove-advice function class name))) (error "ad-remove-advice: `%s' is not advised" function))) +(declare-function comp-subr-trampoline-install "comp") + ;;;###autoload (defun ad-add-advice (function advice class position) "Add a piece of ADVICE to FUNCTION's list of advices in CLASS. diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el index 9e4d8cf1aa..4417082971 100644 --- a/lisp/emacs-lisp/find-func.el +++ b/lisp/emacs-lisp/find-func.el @@ -178,6 +178,8 @@ find-library--load-name (setq name rel)))) (unless (equal name library) name))) +(defvar comp-eln-to-el-h) + (defun find-library-name (library) "Return the absolute file name of the Emacs Lisp source of LIBRARY. LIBRARY should be a string (the name of the library)." diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el index 0396132585..4a55dbfcd5 100644 --- a/lisp/emacs-lisp/nadvice.el +++ b/lisp/emacs-lisp/nadvice.el @@ -316,6 +316,8 @@ add-function `(advice--add-function ,where (gv-ref ,(advice--normalize-place place)) ,function ,props)) +(declare-function comp-subr-trampoline-install "comp") + ;;;###autoload (defun advice--add-function (where ref function props) (when (and (boundp 'comp-ctxt) diff --git a/lisp/files.el b/lisp/files.el index 833a188b03..1d330ce87b 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -900,6 +900,8 @@ load-file (read-file-name "Load file: " nil nil 'lambda)))) (load (expand-file-name file) nil nil t)) +(defvar comp-eln-to-el-h) + (defun locate-file (filename path &optional suffixes predicate) "Search for FILENAME through PATH. If found, return the absolute file name of FILENAME; otherwise diff --git a/lisp/help.el b/lisp/help.el index 4d0c4d5d98..f51f7f19c4 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1320,6 +1320,8 @@ help-add-fundoc-usage (error "Unrecognized usage format")) (help--make-usage-docstring 'fn arglist))))) +(declare-function subr-native-lambda-list "data.c") + (defun help-function-arglist (def &optional preserve-names) "Return a formal argument list for the function DEF. If PRESERVE-NAMES is non-nil, return a formal arglist that uses -- 2.28.0 ------=_Part_142409_213898088.1602292736929--