unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Brian Leung via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 43892@debbugs.gnu.org
Subject: bug#43892: [PATCH] Native comp: fix compilation warnings
Date: Sat, 10 Oct 2020 00:35:58 +0200 (CEST)	[thread overview]
Message-ID: <306152990.137422.1602282958454@ichabod.co-bxl> (raw)
In-Reply-To: <254787322.135820.1602279892520@ichabod.co-bxl>

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

I found another warning, so please look at this patch instead, which supersedes the other one I sent.

-- 
Sent with https://mailfence.com
Secure and private email

[-- Attachment #2: File Attachment: 0001-Fix-some-compilation-warnings.patch --]
[-- Type: text/x-diff, Size: 3382 bytes --]

From f4de89bc3a2ebdeeb32586c283c87a3266ec8e0d Mon Sep 17 00:00:00 2001
From: Brian Leung <leungbk@mailfence.com>
Date: Fri, 9 Oct 2020 14:35:26 -0700
Subject: [PATCH] ; Fix some compilation warnings

---
 lisp/emacs-lisp/advice.el    | 2 ++
 lisp/emacs-lisp/comp.el      | 2 ++
 lisp/emacs-lisp/find-func.el | 2 ++
 lisp/emacs-lisp/nadvice.el   | 2 ++
 lisp/files.el                | 2 ++
 lisp/help.el                 | 2 ++
 6 files changed, 12 insertions(+)

diff --git a/lisp/emacs-lisp/advice.el b/lisp/emacs-lisp/advice.el
index fb67de3a02..509e255191 100644
--- a/lisp/emacs-lisp/advice.el
+++ b/lisp/emacs-lisp/advice.el
@@ -2052,6 +2052,8 @@ ad-remove-advice
 		 function class name)))
     (error "ad-remove-advice: `%s' is not advised" function)))
 
+(declare-function comp-subr-trampoline-install "comp")
+
 ;;;###autoload
 (defun ad-add-advice (function advice class position)
   "Add a piece of ADVICE to FUNCTION's list of advices in CLASS.
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 763d44a23e..4cc0145e3b 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -2613,6 +2613,8 @@ comp-tampoline-compile
       finally (error "Can't find a writable directory in \
 `comp-eln-load-path'")))))
 
+(defvar comp-installed-trampolines-h)
+
 ;;;###autoload
 (defun comp-subr-trampoline-install (subr-name)
   "Make SUBR-NAME effectively advice-able when called from native code."
diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el
index 9e4d8cf1aa..4417082971 100644
--- a/lisp/emacs-lisp/find-func.el
+++ b/lisp/emacs-lisp/find-func.el
@@ -178,6 +178,8 @@ find-library--load-name
             (setq name rel))))
     (unless (equal name library) name)))
 
+(defvar comp-eln-to-el-h)
+
 (defun find-library-name (library)
   "Return the absolute file name of the Emacs Lisp source of LIBRARY.
 LIBRARY should be a string (the name of the library)."
diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index 0396132585..4a55dbfcd5 100644
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -316,6 +316,8 @@ add-function
   `(advice--add-function ,where (gv-ref ,(advice--normalize-place place))
                          ,function ,props))
 
+(declare-function comp-subr-trampoline-install "comp")
+
 ;;;###autoload
 (defun advice--add-function (where ref function props)
   (when (and (boundp 'comp-ctxt)
diff --git a/lisp/files.el b/lisp/files.el
index 833a188b03..1d330ce87b 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -900,6 +900,8 @@ load-file
 		       (read-file-name "Load file: " nil nil 'lambda))))
   (load (expand-file-name file) nil nil t))
 
+(defvar comp-eln-to-el-h)
+
 (defun locate-file (filename path &optional suffixes predicate)
   "Search for FILENAME through PATH.
 If found, return the absolute file name of FILENAME; otherwise
diff --git a/lisp/help.el b/lisp/help.el
index 4d0c4d5d98..f51f7f19c4 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -1320,6 +1320,8 @@ help-add-fundoc-usage
                   (error "Unrecognized usage format"))
 	      (help--make-usage-docstring 'fn arglist)))))
 
+(declare-function subr-native-lambda-list "data.c")
+
 (defun help-function-arglist (def &optional preserve-names)
   "Return a formal argument list for the function DEF.
 If PRESERVE-NAMES is non-nil, return a formal arglist that uses
-- 
2.28.0


  reply	other threads:[~2020-10-09 22:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 21:44 bug#43892: [PATCH] Native-comp: fix compilation warnings Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-09 22:35 ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-10-10  1:19   ` bug#43892: [PATCH] Native comp: " Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12  7:05     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 17:40       ` Brian Leung via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-12 19:28         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=306152990.137422.1602282958454@ichabod.co-bxl \
    --to=bug-gnu-emacs@gnu.org \
    --cc=43892@debbugs.gnu.org \
    --cc=leungbk@mailfence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).