Bug in etags ".." code

Bug in etags ".." code

[Tom Tromey]

I ran etags like this:

etags ./eval.c -o $(pwd)//.retags.d/Q

Note the double "/".

The resulting tags file contains this line:

../../eval.c,567

But this is wrong, there should be only a single "..".

I think relative_filename needs to handle the situation where multiple
"/"s appear consecutively.  The appended patch worked for me.

Tom

*** etags.c	07 Feb 2008 19:34:52 -0700	3.82
--- etags.c	02 Mar 2008 17:01:30 -0700	
***************
*** 6792,6799 ****
  
    /* Build a sequence of "../" strings for the resulting relative file name. */
    i = 0;
    while ((dp = etags_strchr (dp + 1, '/')) != NULL)
!     i += 1;
    res = xnew (3*i + strlen (fp + 1) + 1, char);
    res[0] = '\0';
    while (i-- > 0)
--- 6792,6805 ----
  
    /* Build a sequence of "../" strings for the resulting relative file name. */
    i = 0;
+   while (*dp == '/')
+     ++dp;
    while ((dp = etags_strchr (dp + 1, '/')) != NULL)
!     {
!       i += 1;
!       while (*dp == '/')
! 	++dp;
!     }
    res = xnew (3*i + strlen (fp + 1) + 1, char);
    res[0] = '\0';
    while (i-- > 0)

Re: Bug in etags ".." code

[Chong Yidong]

Tom Tromey <tromey@redhat.com> writes:

> I think relative_filename needs to handle the situation where multiple
> "/"s appear consecutively.  The appended patch worked for me.

Thanks.  I'll check it in after the Emacs 22.2 release.

bug#32: marked as done (Bug in etags ".." code)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]


Your message dated Thu, 29 May 2008 16:18:48 -0400
with message-id <jwvr6bkampj.fsf-monnier+emacsbugreports@gnu.org>
and subject line Re: Bug in etags ".." code
has caused the Emacs bug report #32,
regarding Bug in etags ".." code
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
32: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=32
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 6112 bytes --]

From: Tom Tromey <tromey@redhat.com>
To: bug-gnu-emacs@gnu.org
Subject: Bug in etags ".." code
Date: Sun, 02 Mar 2008 17:02:48 -0700
Message-ID: <m34pboekt3.fsf@fleche.redhat.com>

I ran etags like this:

etags ./eval.c -o $(pwd)//.retags.d/Q

Note the double "/".

The resulting tags file contains this line:

../../eval.c,567

But this is wrong, there should be only a single "..".

I think relative_filename needs to handle the situation where multiple
"/"s appear consecutively.  The appended patch worked for me.

Tom

*** etags.c	07 Feb 2008 19:34:52 -0700	3.82
--- etags.c	02 Mar 2008 17:01:30 -0700	
***************
*** 6792,6799 ****
  
    /* Build a sequence of "../" strings for the resulting relative file name. */
    i = 0;
    while ((dp = etags_strchr (dp + 1, '/')) != NULL)
!     i += 1;
    res = xnew (3*i + strlen (fp + 1) + 1, char);
    res[0] = '\0';
    while (i-- > 0)
--- 6792,6805 ----
  
    /* Build a sequence of "../" strings for the resulting relative file name. */
    i = 0;
+   while (*dp == '/')
+     ++dp;
    while ((dp = etags_strchr (dp + 1, '/')) != NULL)
!     {
!       i += 1;
!       while (*dp == '/')
! 	++dp;
!     }
    res = xnew (3*i + strlen (fp + 1) + 1, char);
    res[0] = '\0';
    while (i-- > 0)




[-- Attachment #3: Type: message/rfc822, Size: 1074 bytes --]

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 32-done@emacsbugs.donarmstrong.com
Subject: Re: Bug in etags ".." code
Date: Thu, 29 May 2008 16:18:48 -0400
Message-ID: <jwvr6bkampj.fsf-monnier+emacsbugreports@gnu.org>

Thanks, installed,


        Stefan

bug#735: Bug in etags ".." code

[Francesco Potorti`]

Ok, it has been quite some time since you reported this bug, but at last
I managed to look at it during my vacations...

> I ran etags like this:
> 
> etags ./eval.c -o $(pwd)//.retags.d/Q
> 
> Note the double "/".
> 
> The resulting tags file contains this line:
> 
> ../../eval.c,567
> 
> But this is wrong, there should be only a single "..".

Thank you for the patch for collapsing multiple consecutive slashes in
file names.  I generalised it by canonicalising all file names as soon
as they are read into etags.  I just installed the change into the
trunk.

I did not install it into the pretest branch yet.
Since this is a bug, it probably should go into the pretest branch too.

What do people think?  I am unsure whether this is serious enough to
grant a patch to the pretest branch,

P.S.
Please put me in Cc, as I discovered that I am no more subscribed to the
list, and a new subscription is in progress.

bug#735: marked as done (Bug in etags ".." code)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]


Your message dated Wed, 20 Aug 2008 18:31:16 -0400
with message-id <87bpzns4i3.fsf@cyd.mit.edu>
and subject line Re: Bug in etags ".." code
has caused the Emacs bug report #735,
regarding Bug in etags ".." code
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
735: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=735
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3480 bytes --]

From: Francesco Potorti` <pot@gnu.org>
To: bug-gnu-emacs@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, Tom Tromey <tromey@redhat.com>
Subject: Re: Bug in etags ".." code
Date: Sun, 17 Aug 2008 02:19:48 +0200
Message-ID: <E1KUVzo-0000tw-Iq@tucano.isti.cnr.it>

Ok, it has been quite some time since you reported this bug, but at last
I managed to look at it during my vacations...

> I ran etags like this:
> 
> etags ./eval.c -o $(pwd)//.retags.d/Q
> 
> Note the double "/".
> 
> The resulting tags file contains this line:
> 
> ../../eval.c,567
> 
> But this is wrong, there should be only a single "..".

Thank you for the patch for collapsing multiple consecutive slashes in
file names.  I generalised it by canonicalising all file names as soon
as they are read into etags.  I just installed the change into the
trunk.

I did not install it into the pretest branch yet.
Since this is a bug, it probably should go into the pretest branch too.

What do people think?  I am unsure whether this is serious enough to
grant a patch to the pretest branch,

P.S.
Please put me in Cc, as I discovered that I am no more subscribed to the
list, and a new subscription is in progress.




[-- Attachment #3: Type: message/rfc822, Size: 1507 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Francesco Potorti <pot@gnu.org>
Cc: 735-done@emacsbugs.donarmstrong.com
Subject: Re: Bug in etags ".." code
Date: Wed, 20 Aug 2008 18:31:16 -0400
Message-ID: <87bpzns4i3.fsf@cyd.mit.edu>

> Thank you for the patch for collapsing multiple consecutive slashes in
> file names.  I generalised it by canonicalising all file names as soon
> as they are read into etags.  I just installed the change into the
> trunk.
>
> I did not install it into the pretest branch yet.  Since this is a
> bug, it probably should go into the pretest branch too.
>
> What do people think?  I am unsure whether this is serious enough to
> grant a patch to the pretest branch,

Thanks for checking in your fix to the trunk.  I think we can leave it
out of the pretest branch.