From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#32: marked as done (Bug in etags ".." code) Date: Thu, 29 May 2008 13:25:06 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1212092705-3440-0" X-Trace: ger.gmane.org 1212093129 4808 80.91.229.12 (29 May 2008 20:32:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 May 2008 20:32:09 +0000 (UTC) To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 29 22:32:50 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K1ono-0007tT-LN for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 May 2008 22:32:49 +0200 Original-Received: from localhost ([127.0.0.1]:37791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K1on3-0002Z0-2B for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 May 2008 16:32:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K1omv-0002UW-Bt for bug-gnu-emacs@gnu.org; Thu, 29 May 2008 16:31:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K1omu-0002Tk-HO for bug-gnu-emacs@gnu.org; Thu, 29 May 2008 16:31:52 -0400 Original-Received: from [199.232.76.173] (port=55982 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K1omu-0002Td-CQ for bug-gnu-emacs@gnu.org; Thu, 29 May 2008 16:31:52 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42896) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K1omo-0006PV-J1; Thu, 29 May 2008 16:31:47 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m4TKVitf005714; Thu, 29 May 2008 13:31:44 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m4TKP67k003585; Thu, 29 May 2008 13:25:06 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 32 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:18168 Archived-At: This is a multi-part message in MIME format... ------------=_1212092705-3440-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Thu, 29 May 2008 16:18:48 -0400 with message-id and subject line Re: Bug in etags ".." code has caused the Emacs bug report #32, regarding Bug in etags ".." code to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 32: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D32 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1212092705-3440-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Status: No, score=1.3 required=4.0 tests=FOURLA,IMPRONONCABLE_1, MURPHY_DRUGS_REL8,MURPHY_WRONG_WORD2 autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 3 Mar 2008 03:10:35 +0000 Received: from ironport2-out.pppoe.ca (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m233ATeo026201 for ; Sun, 2 Mar 2008 19:10:30 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao8CABL7ykfO+LKX/2dsb2JhbACRd5lsgQA X-IronPort-AV: E=Sophos;i="4.25,435,1199682000"; d="scan'208";a="15471115" Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 02 Mar 2008 22:10:15 -0500 Received: from pastel.home ([206.248.178.151]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id JGN47615 for ; Sun, 02 Mar 2008 22:10:15 -0500 Received: by pastel.home (Postfix, from userid 20848) id 5096E8279; Sun, 2 Mar 2008 22:10:15 -0500 (EST) Resent-Message-ID: Resent-To: submit@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-Date: Sun, 02 Mar 2008 22:10:15 -0500 X-Original-To: monnier@iro.umontreal.ca Delivered-To: monnier@iro.umontreal.ca Received: from perlin.iro.umontreal.ca (perlin.iro.umontreal.ca [132.204.24.51]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id A8F5E2CF86E for ; Sun, 2 Mar 2008 21:47:54 -0500 (EST) Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by perlin.iro.umontreal.ca (Postfix) with ESMTP id 77A1C14821C for ; Sun, 2 Mar 2008 21:47:48 -0500 (EST) Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JW0iS-0004tB-9u for monnier@iro.umontreal.ca; Sun, 02 Mar 2008 21:47:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JVyvx-000481-Pt for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JVyvv-00047p-0r for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:36 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JVyvu-00047m-SE for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:34 -0500 Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JVyvu-0000aD-Ex for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2008 19:53:34 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m230rS0O006677 for ; Sun, 2 Mar 2008 19:53:28 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m230rRWM027123 for ; Sun, 2 Mar 2008 19:53:27 -0500 Received: from opsy.redhat.com (vpn-14-59.rdu.redhat.com [10.11.14.59]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m230rRSs023113; Sun, 2 Mar 2008 19:53:27 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id ED13737811A; Sun, 2 Mar 2008 17:02:48 -0700 (MST) To: bug-gnu-emacs@gnu.org From: Tom Tromey X-Attribution: Tom Date: Sun, 02 Mar 2008 17:02:48 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-Mailman-Approved-At: Sun, 02 Mar 2008 21:47:40 -0500 Subject: Bug in etags ".." code X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Tom Tromey List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Errors-To: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.94, requis 5, BAYES_00 -2.60, RECEIVED_FROM_NOUNK 0.66, SPF_HELO_PASS -0.00) X-DIRO-MailScanner-From: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org I ran etags like this: etags ./eval.c -o $(pwd)//.retags.d/Q Note the double "/". The resulting tags file contains this line: ../../eval.c,567 But this is wrong, there should be only a single "..". I think relative_filename needs to handle the situation where multiple "/"s appear consecutively. The appended patch worked for me. Tom *** etags.c 07 Feb 2008 19:34:52 -0700 3.82 --- etags.c 02 Mar 2008 17:01:30 -0700 *************** *** 6792,6799 **** /* Build a sequence of "../" strings for the resulting relative file name. */ i = 0; while ((dp = etags_strchr (dp + 1, '/')) != NULL) ! i += 1; res = xnew (3*i + strlen (fp + 1) + 1, char); res[0] = '\0'; while (i-- > 0) --- 6792,6805 ---- /* Build a sequence of "../" strings for the resulting relative file name. */ i = 0; + while (*dp == '/') + ++dp; while ((dp = etags_strchr (dp + 1, '/')) != NULL) ! { ! i += 1; ! while (*dp == '/') ! ++dp; ! } res = xnew (3*i + strlen (fp + 1) + 1, char); res[0] = '\0'; while (i-- > 0) ------------=_1212092705-3440-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.7 required=4.0 tests=AWL,BAYES_00,FAKE_REPLY_C, HELO_LH_HOME,RDNS_DYNAMIC autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 32-done) by emacsbugs.donarmstrong.com; 29 May 2008 20:18:52 +0000 Received: from ceviche.home (206-248-174-248.dsl.teksavvy.com [206.248.174.248]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m4TKIn5q002177 for <32-done@emacsbugs.donarmstrong.com>; Thu, 29 May 2008 13:18:50 -0700 Received: by ceviche.home (Postfix, from userid 20848) id 90744B41E2; Thu, 29 May 2008 16:18:48 -0400 (EDT) From: Stefan Monnier To: 32-done@emacsbugs.donarmstrong.com Subject: Re: Bug in etags ".." code Message-ID: Date: Thu, 29 May 2008 16:18:48 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Thanks, installed, Stefan ------------=_1212092705-3440-0--