unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: bug-gnu-emacs@gnu.org
Subject: Bug in etags ".." code
Date: Sun, 02 Mar 2008 17:02:48 -0700	[thread overview]
Message-ID: <m34pboekt3.fsf@fleche.redhat.com> (raw)

I ran etags like this:

etags ./eval.c -o $(pwd)//.retags.d/Q

Note the double "/".

The resulting tags file contains this line:

../../eval.c,567

But this is wrong, there should be only a single "..".

I think relative_filename needs to handle the situation where multiple
"/"s appear consecutively.  The appended patch worked for me.

Tom

*** etags.c	07 Feb 2008 19:34:52 -0700	3.82
--- etags.c	02 Mar 2008 17:01:30 -0700	
***************
*** 6792,6799 ****
  
    /* Build a sequence of "../" strings for the resulting relative file name. */
    i = 0;
    while ((dp = etags_strchr (dp + 1, '/')) != NULL)
!     i += 1;
    res = xnew (3*i + strlen (fp + 1) + 1, char);
    res[0] = '\0';
    while (i-- > 0)
--- 6792,6805 ----
  
    /* Build a sequence of "../" strings for the resulting relative file name. */
    i = 0;
+   while (*dp == '/')
+     ++dp;
    while ((dp = etags_strchr (dp + 1, '/')) != NULL)
!     {
!       i += 1;
!       while (*dp == '/')
! 	++dp;
!     }
    res = xnew (3*i + strlen (fp + 1) + 1, char);
    res[0] = '\0';
    while (i-- > 0)




             reply	other threads:[~2008-03-03  0:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <jwvr6bkampj.fsf-monnier+emacsbugreports@gnu.org>
2008-03-03  0:02 ` Tom Tromey [this message]
2008-03-05 20:57   ` Bug in etags ".." code Chong Yidong
2008-05-29 20:25   ` bug#32: marked as done (Bug in etags ".." code) Emacs bug Tracking System
2008-08-17  0:19     ` bug#735: Bug in etags ".." code Francesco Potorti`
2008-08-20 22:35       ` bug#735: marked as done (Bug in etags ".." code) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34pboekt3.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).