bug#3746: marked as done (M-r in comint mode should use isearch)

[owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Your message dated Mon, 30 Nov 2009 18:12:45 +0200
with message-id <87ocmknicw.fsf@mail.jurta.org>
and subject line Re: bug#3746: M-r in comint mode should use isearch
has caused the Emacs bug report #3746,
regarding M-r in comint mode should use isearch
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3746: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3746
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2720 bytes --]

From: Dan Nicolaescu <dann@ics.uci.edu>
To: bug-gnu-emacs <bug-gnu-emacs@gnu.org>
Subject: M-r in comint mode should use isearch
Date: Fri, 3 Jul 2009 06:26:41 -0700 (PDT)
Message-ID: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu>


When using the minibuffer for example doing:

M-x
then
C-r
will use isearch to search the history.  This is nice because it shows
the items that are matched.

M-r should to the same thing when used in comint, right now it's hard to
tell if it matches anything before typing RET



[-- Attachment #3: Type: message/rfc822, Size: 3880 bytes --]

From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 3746-done@emacsbugs.donarmstrong.com, Dan Nicolaescu <dann@ics.uci.edu>
Subject: Re: bug#3746: M-r in comint mode should use isearch
Date: Mon, 30 Nov 2009 18:12:45 +0200
Message-ID: <87ocmknicw.fsf@mail.jurta.org>

>> What would be the "UI" (e.g. key-binding) for it?
>> Only the comint-history-isearch defcustom?
>
> One way to use this feature is to configure `comint-history-isearch' to
> a non-nil value.  But I think it should be nil by default because after
> trying to use it with non-nil values I found it counterintuitive since
> in comint mode on typing `C-r' I expect it to search in the comint output,
> not in the input history.
>
> There is no such problem in bash where C-r searches in the input history,
> since there is no way to search in the bash output.
>
> So we need another key to search in the history.  However, this is
> a controversial issue, so I will defer to others to decide what key
> to use for that.  (In the code I sent, there is a command
> `comint-history-isearch-backward' that could be bound to any key.)

To help to select a key binding, below is a table of current key bindings:

* Bash:

M-p    non-incremental-reverse-search-history
M-n    non-incremental-forward-search-history

M-r    revert-line

C-r    reverse-search-history
C-s    forward-search-history

C-p    previous-history
C-n    next-history

* Emacs comint mode:

M-p    comint-previous-input
M-n    comint-next-input

M-r    comint-previous-matching-input
M-s    comint-next-matching-input

C-r    isearch-backward
C-s    isearch-forward

C-p    previous-line
C-n    next-line

So I now agree with the subject of bug#3746 that says

  "M-r in comint mode should use isearch"

I marked bug#3746 as closed with M-r bound to the new command that uses
Isearch, added corresponding menu items, removed M-s (that was
symmetrical to M-r) to expose the global key binding M-s for comint
with removing one problem from the list of problems in FOR-RELEASE
that used to say:

  3. Shell mode binds `M-s' to `comint-next-matching-input'.
     This key binding can be changed later when we will implement
     incremental search through the shell history.

-- 
Juri Linkov
http://www.jurta.org/emacs/