From: Juri Linkov <juri@jurta.org>
To: Dan Nicolaescu <dann@ics.uci.edu>
Cc: 3746@emacsbugs.donarmstrong.com
Subject: bug#3746: M-r in comint mode should use isearch
Date: Thu, 19 Nov 2009 19:30:43 +0200 [thread overview]
Message-ID: <877htmbj2s.fsf@mail.jurta.org> (raw)
In-Reply-To: <87ljmxo5pw.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 10 Jul 2009 01:19:11 +0300")
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
Please see the attached code that implements isearch in comint mode.
It is not posted as a patch because it has one remaining problem:
`comint-previous-input' and `comint-next-input' don't signal an error
at the beginning/end of the history ring. This is unlike the minibuffer's
commands `previous-history-element' and `next-history-element' that
signal an error at the beginning/end of the minibuffer history.
So Isearch on the minibuffer history can stop and wrap. But in comint
mode Isearch with an unmatched string doesn't stop and goes into the loop.
Maybe we should change `comint-previous-input' and `comint-next-input'
to signal an error at the beginning/end of the history ring?
[-- Attachment #2: comint.history.isearch.el --]
[-- Type: application/emacs-lisp, Size: 7713 bytes --]
[-- Attachment #3: Type: text/plain, Size: 45 bytes --]
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2009-11-19 17:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ocmknicw.fsf@mail.jurta.org>
2009-07-03 13:26 ` bug#3746: M-r in comint mode should use isearch Dan Nicolaescu
2009-07-03 23:36 ` Juri Linkov
2009-07-05 15:03 ` Dan Nicolaescu
2009-07-07 0:09 ` Juri Linkov
2009-07-07 1:21 ` Dan Nicolaescu
2009-07-08 0:45 ` Juri Linkov
2009-07-08 5:53 ` Drew Adams
2009-07-08 23:27 ` Juri Linkov
2009-07-08 23:42 ` Lennart Borgman
2009-07-09 15:01 ` Drew Adams
2009-07-09 22:16 ` Juri Linkov
2009-07-09 22:32 ` Drew Adams
2009-07-09 23:05 ` Juri Linkov
2009-07-09 23:15 ` Drew Adams
2009-07-08 23:49 ` Dan Nicolaescu
2009-07-09 22:19 ` Juri Linkov
2009-11-19 17:30 ` Juri Linkov [this message]
2009-11-19 21:12 ` Stefan Monnier
2009-11-20 9:28 ` Juri Linkov
2009-11-23 20:39 ` Juri Linkov
2009-11-30 16:30 ` bug#3746: marked as done (M-r in comint mode should use isearch) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877htmbj2s.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=3746@emacsbugs.donarmstrong.com \
--cc=dann@ics.uci.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).