From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#3746: marked as done (M-r in comint mode should use isearch) Date: Mon, 30 Nov 2009 16:30:12 +0000 Message-ID: References: <87ocmknicw.fsf@mail.jurta.org> <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1259598612-32379-0" X-Trace: ger.gmane.org 1259601075 6415 80.91.229.12 (30 Nov 2009 17:11:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 30 Nov 2009 17:11:15 +0000 (UTC) To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 30 18:11:08 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NF9mC-00078J-VJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 18:11:07 +0100 Original-Received: from localhost ([127.0.0.1]:48424 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF9mC-00026v-Ib for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Nov 2009 12:11:04 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF9PX-00085B-50 for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF9PP-000825-JR for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:36 -0500 Original-Received: from [199.232.76.173] (port=58697 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF9PM-00080x-TP for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:29 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42069) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NF9PL-0007OM-Tl for bug-gnu-emacs@gnu.org; Mon, 30 Nov 2009 11:47:28 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUGlN8o001381; Mon, 30 Nov 2009 08:47:24 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nAUGUCCr032424; Mon, 30 Nov 2009 08:30:12 -0800 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 3746 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33070 Archived-At: This is a multi-part message in MIME format... ------------=_1259598612-32379-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 30 Nov 2009 18:12:45 +0200 with message-id <87ocmknicw.fsf@mail.jurta.org> and subject line Re: bug#3746: M-r in comint mode should use isearch has caused the Emacs bug report #3746, regarding M-r in comint mode should use isearch to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 3746: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D3746 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1259598612-32379-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 3 Jul 2009 18:15:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.1 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n63IF2ja005442 for ; Fri, 3 Jul 2009 11:15:03 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MMioX-0000hr-EJ for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MMioT-0000cb-R7 for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:29 -0400 Received: from [199.232.76.173] (port=40895 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MMioT-0000cY-Lp for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:25 -0400 Received: from sallyv2.ics.uci.edu ([128.195.1.120]:47612) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MMioT-0005wj-93 for bug-gnu-emacs@gnu.org; Fri, 03 Jul 2009 09:28:25 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n63DQfRL027172 for ; Fri, 3 Jul 2009 06:26:41 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n63DQfPA027629; Fri, 3 Jul 2009 06:26:41 -0700 (PDT) Date: Fri, 3 Jul 2009 06:26:41 -0700 (PDT) Message-Id: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: M-r in comint mode should use isearch Lines: 11 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n63DQfRL027172 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) When using the minibuffer for example doing: M-x then C-r will use isearch to search the history. This is nice because it shows the items that are matched. M-r should to the same thing when used in comint, right now it's hard to tell if it matches anything before typing RET ------------=_1259598612-32379-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3746-done) by emacsbugs.donarmstrong.com; 30 Nov 2009 16:22:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUGMGpn031750 for <3746-done@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 08:22:18 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.52.137.cable.starman.ee [82.131.52.137]) by mx2.starman.ee (Postfix) with ESMTP id D5E5C3F4047; Mon, 30 Nov 2009 18:22:10 +0200 (EET) From: Juri Linkov To: Stefan Monnier Cc: 3746-done@emacsbugs.donarmstrong.com, Dan Nicolaescu Subject: Re: bug#3746: M-r in comint mode should use isearch Organization: JURTA References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> <87ljmxo5pw.fsf@mail.jurta.org> <877htmbj2s.fsf@mail.jurta.org> <87vdh51vt2.fsf@mail.jurta.org> Date: Mon, 30 Nov 2009 18:12:45 +0200 In-Reply-To: <87vdh51vt2.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 20 Nov 2009 11:28:09 +0200") Message-ID: <87ocmknicw.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> What would be the "UI" (e.g. key-binding) for it? >> Only the comint-history-isearch defcustom? > > One way to use this feature is to configure `comint-history-isearch' to > a non-nil value. But I think it should be nil by default because after > trying to use it with non-nil values I found it counterintuitive since > in comint mode on typing `C-r' I expect it to search in the comint output, > not in the input history. > > There is no such problem in bash where C-r searches in the input history, > since there is no way to search in the bash output. > > So we need another key to search in the history. However, this is > a controversial issue, so I will defer to others to decide what key > to use for that. (In the code I sent, there is a command > `comint-history-isearch-backward' that could be bound to any key.) To help to select a key binding, below is a table of current key bindings: * Bash: M-p non-incremental-reverse-search-history M-n non-incremental-forward-search-history M-r revert-line C-r reverse-search-history C-s forward-search-history C-p previous-history C-n next-history * Emacs comint mode: M-p comint-previous-input M-n comint-next-input M-r comint-previous-matching-input M-s comint-next-matching-input C-r isearch-backward C-s isearch-forward C-p previous-line C-n next-line So I now agree with the subject of bug#3746 that says "M-r in comint mode should use isearch" I marked bug#3746 as closed with M-r bound to the new command that uses Isearch, added corresponding menu items, removed M-s (that was symmetrical to M-r) to expose the global key binding M-s for comint with removing one problem from the list of problems in FOR-RELEASE that used to say: 3. Shell mode binds `M-s' to `comint-next-matching-input'. This key binding can be changed later when we will implement incremental search through the shell history. -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1259598612-32379-0--