From: Dan Nicolaescu <dann@ics.uci.edu>
To: Juri Linkov <juri@jurta.org>
Cc: 3746@emacsbugs.donarmstrong.com
Subject: bug#3746: M-r in comint mode should use isearch
Date: Wed, 8 Jul 2009 16:49:20 -0700 (PDT) [thread overview]
Message-ID: <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> (raw)
In-Reply-To: <87skh8ynnm.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 08 Jul 2009 03:45:05 +0300")
Juri Linkov <juri@jurta.org> writes:
> > > > The problem with that is that C-s (and C-r) already have bindings in
> > > > comint modes, and changing them would not be liked by most users.
> > > > Doing M-r and then C-s/C-r seems a bit cumbersome.
> > > > IMHO just using M-r for incremental history search will provide no
> > > > surprises for the user, and it seems like a natural extension of the
> > > > current behavior.
> > >
> > > Currently M-r typed in the shell buffer activates the minibuffer with
> > > the prompt "Previous input matching (regexp): ". I doubt that users
> > > will like to see Isearch activated instead of this minibuffer.
> >
> > Why not? It does provide the same functionality and it seems easier to
> > use. Maybe the prompt would need to be adjusted, but, IMHO, it's
> > doubtful the users would be unpleasantly surprised by the behavior...
>
> M-r has a different UI. Its main difference that it is a non-incremental
> regexp search unlike C-s that is an incremental string search.
Is there any reason not to have an incremental search for M-r too?
> Both bash and the Emacs minibuffer activate Isearch on C-s, so it
> would be natural to do the same in shell buffers. We could try the
> same context-dependent dwim approach used by the option of
> `dired-isearch-filenames', i.e. "When point is on a file name
> initially, search file names". So when point is on the shell prompt
> then run Isearch on the shell history, otherwise run Isearch on the
> shell buffer.
That sounds fine, but it's not exclusive with M-r being an incremental
search too.
We are at the beginning of a release cycle, so we can experiment, if the
users hate the change, there's enough time to change back.
> What to do with the prompt is more difficult problem. Bash replaces the
> shell prompt with the search prompt. Perhaps we should do the same.
Agreed.
next prev parent reply other threads:[~2009-07-08 23:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ocmknicw.fsf@mail.jurta.org>
2009-07-03 13:26 ` bug#3746: M-r in comint mode should use isearch Dan Nicolaescu
2009-07-03 23:36 ` Juri Linkov
2009-07-05 15:03 ` Dan Nicolaescu
2009-07-07 0:09 ` Juri Linkov
2009-07-07 1:21 ` Dan Nicolaescu
2009-07-08 0:45 ` Juri Linkov
2009-07-08 5:53 ` Drew Adams
2009-07-08 23:27 ` Juri Linkov
2009-07-08 23:42 ` Lennart Borgman
2009-07-09 15:01 ` Drew Adams
2009-07-09 22:16 ` Juri Linkov
2009-07-09 22:32 ` Drew Adams
2009-07-09 23:05 ` Juri Linkov
2009-07-09 23:15 ` Drew Adams
2009-07-08 23:49 ` Dan Nicolaescu [this message]
2009-07-09 22:19 ` Juri Linkov
2009-11-19 17:30 ` Juri Linkov
2009-11-19 21:12 ` Stefan Monnier
2009-11-20 9:28 ` Juri Linkov
2009-11-23 20:39 ` Juri Linkov
2009-11-30 16:30 ` bug#3746: marked as done (M-r in comint mode should use isearch) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907082349.n68NnKRj025444@godzilla.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=3746@emacsbugs.donarmstrong.com \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).